Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking issue for moving custom-page-sizes to phase 3 #36

Open
fitzgen opened this issue Jan 22, 2025 · 0 comments
Open

Tracking issue for moving custom-page-sizes to phase 3 #36

fitzgen opened this issue Jan 22, 2025 · 0 comments

Comments

@fitzgen
Copy link
Collaborator

fitzgen commented Jan 22, 2025

The entry requirements for phase 3 are

Entry requirements:

  • Test suite has been updated to cover the feature in its forked repo.
  • The test suite should run against some implementation, though it need not be the reference interpreter.
  • Updates on the actual spec document and reference interpreter are NOT yet required (but can happen earlier).

These entry requirements are technically satisfied today:

  • this repo has a test suite that fully covers the custom-page-sizes feature, and
  • these tests are passing in Wasmtime's implementation.1

The next big tasks for advancing this proposal are to

  • update the spec,
  • implement support in the spec interpreter, and
  • implement toolchain support in wasm-ld and compilers using it.

These are all items that fall under the work that happens during phase 3:

During this phase, the following proceeds in parallel:

  • Engines implement the feature (where applicable).
  • The spec document in the forked repo is updated to include the full English prose and formalization.
  • The reference interpreter in the forked repo is updated to include a complete implementation of the feature.
  • The feature is implemented in toolchains.
  • Remaining open questions are resolved.

So I believe the proposal is more than ready to advance to phase 3.

However, before taking the phase advancement to a CG meeting, I wanted to open up an issue for discussion. Does anyone believe there are any extant phase 2 tasks that should be completed before this proposal advances to phase 3? Thanks!

Footnotes

  1. I do not know for sure whether the three other implementations run the spec tests or their own custom test suites.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant