Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local rebuild fails on non-empty dist directory #486

Closed
abrown opened this issue Sep 5, 2024 · 1 comment
Closed

Local rebuild fails on non-empty dist directory #486

abrown opened this issue Sep 5, 2024 · 1 comment

Comments

@abrown
Copy link
Collaborator

abrown commented Sep 5, 2024

To avoid the issues in #485, I can manually set -DWASI_SDK_INCLUDE_TESTS=OFF in ci/build.sh and disable building the tests, but if a previous build has failed, the build will fail because a dist directory is not empty:

$ WASI_SDK_CI_SKIP_TESTS=1 ci/build.sh
...
[2/2] cd /home/abrown/Code/wasi-sdk/build/toolchain/dist && cp -R /home/abrown/Code/wasi-sdk/build/toolchain/install
wasi-toolchain-24.6g754aec3d6f58+m-x86_64-linux && /usr/bin/cmake -E tar cfz
/home/abrown/Code/wasi-sdk/build/toolchain/dist/wasi-toolchain-24.6g754aec3d6f58+m-x86_64-linux.tar.gz wasi-toolchain-24.6g754aec3d6f58+m-x86_64-linux &&
/usr/bin/cmake -E rm -rf wasi-toolchain-24.6g754aec3d6f58+m-x86_64-linux
+ mv /home/abrown/Code/wasi-sdk/build/toolchain/dist /home/abrown/Code/wasi-sdk/build/dist
mv: cannot overwrite '/home/abrown/Code/wasi-sdk/build/dist/dist': Directory not empty

Could it be that CMake needs some more instructions here to know these artifacts are already built?

@alexcrichton
Copy link
Collaborator

Oh the ./ci/build.sh script isn't necessarily written to be run and rerun locally. For that it probably needs more than a few updates (in addition to handling this dist directory differently). For local development I've been relying on running cmake and ninja manually.

@abrown abrown closed this as completed Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants