Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MIDIPort close() does not cover the "pending" case #201

Open
jazz-soft opened this issue Jul 3, 2019 · 2 comments
Open

MIDIPort close() does not cover the "pending" case #201

jazz-soft opened this issue Jul 3, 2019 · 2 comments
Labels
class: substantive https://www.w3.org/policies/process/#correction-classes Needs Edits https://speced.github.io/spec-maintenance/about/
Milestone

Comments

@jazz-soft
Copy link

The function should probably cancel the pending requests from previously called open()

@cwilso cwilso added this to the V1 milestone Oct 12, 2020
@cwilso cwilso added the Needs Edits https://speced.github.io/spec-maintenance/about/ label Oct 12, 2020
@cwilso
Copy link
Contributor

cwilso commented Oct 12, 2020

Spec should be updated to mandate this.

@mjwilson-google mjwilson-google added the class: substantive https://www.w3.org/policies/process/#correction-classes label Sep 13, 2023
@mjwilson-google mjwilson-google self-assigned this Sep 25, 2023
@mjwilson-google
Copy link
Contributor

I think this is in step 5. of https://webaudio.github.io/web-midi-api/#dfn-algorithm-to-close-a-midiport

Is it as simple as changing this:
"If the output port's .state is not "connected", clear all pending send data and skip to the next step."

to this?
"If the output port's .state is not "connected", or if its .connection is "pending", clear all pending send data and skip to the next step."

@mjwilson-google mjwilson-google removed their assignment Oct 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
class: substantive https://www.w3.org/policies/process/#correction-classes Needs Edits https://speced.github.io/spec-maintenance/about/
Projects
None yet
Development

No branches or pull requests

3 participants