Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate Holey and Standard firmware versions #6

Open
emilecantin opened this issue May 27, 2020 · 2 comments
Open

Integrate Holey and Standard firmware versions #6

emilecantin opened this issue May 27, 2020 · 2 comments

Comments

@emilecantin
Copy link

This issue's aim is to discuss and plan what needs to be done in order to bring back the Holey calibration / kinematic model code back into the main branch.

@krkeegan
Copy link

krkeegan commented Aug 4, 2020

Slowly jumping back into things.

I would highly suggest using a $ setting for the switch between calibration types. In the beginning we used GCode and it is a dangerous proposition (1) we may commandeer a command that might be later enabled on the Maslow; or (2) more importantly, a GCode generator may spit out on of those commands and could create havoc on a user's machine.

@Orob-Maslow
Copy link

The difference is just in the kinematics... I just submitted a pr for supporting a different shield and a few other things, but this should be the next fold-in so a flash is not required to switch from triangular to holey calibration. Any suggestions on what $ number should be used? The z-axis setpoints are stored using B commands. I think they should move to $ commands as well, though really a separate discussion could be had for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants