-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Source-string suggestions without direct editing #10163
Comments
Weblate does not allow adding suggestions if there is no way to accept them. Use https://docs.weblate.org/en/latest/workflows.html#source-strings-reviews instead. |
I am at a loss for why is that not allowed? From my point of view I go to make a suggestion
What I get instead is very often that I just know something that is wrong, What can I do with this info? But I can keep track of where it is by marking as "needs editing", for the local string, even if it is an issue in the source string, as marking source strings locks stuff down. Now what do I do if I see a suggestion (either by comments or the functionality), well I most often go and fix it. I don't control every project, or have write access. It is most often just manual work, and that stuff gets made and picked up in a manner that is easy to deal with. Also, the suggestion functionality should behave the same, regardless of how easy it is to guess whether a project would turn on direct editing or not. It doesn't say in the Zen editor…? Quality should never suffer, and it is harder than it needs to be to have any certainty. |
Having one fuzzy-status that either means something was changed upstream, or isn't quite right downstream, or as the case often is happens to be a disguised source string error without locking all translations, is as problematic as one review-status that anyone can change. Ends up like ddterm/gnome-shell-extension-ddterm#593 (comment) Every time someone notices an error and doesn't do anything about it that is effort lost. If I can make suggestions in translations, Verifiability matters more than anything else. Instead there is a focus on translators only doing translations, coverage meaning completeness in terms of accuracy, and functionality that changes and miscommunicates quality between translators and developers. |
Because there is no way to accept such a suggestion inside Weblate. There is no point in piling up suggestions which cannot be dealt with. There is Source strings reviews exactly for this, but it is opt-in, as there needs to be somebody from the project doing something with the feedback. |
I can't bring myself to see how this wouldn't help the continuous integrated translation that Weblate already is markedly better at. Suggestions are for people thinking they have better ideas, As for what suggestions happen to be are vs. direct changes made as translations, they represent some level of insecurity without real change. That all works, in every language, in every string - except for most of the source strings, where it all matters a lot more. Nobody is limited from taking their own or the suggestions of others to upstream manually, it just isn't convenient per default in Weblate. Be that as it may, suggestions on their own help improve quality, and provide a venue to present things that would be changed directly if possible. We know that these types of ideas just go missing, because the problems they represent end up as fixed in some of the translations. Suggestions don't pile up right now, precisely because of what presents an even bigger inconvenience in going to the full extent of improving source strings, by someone else. As for always making suggestions as suggestions instead of sometimes comments, the real change there Bad source strings is a fixed target. Errors, malice, subpar language and so on can either sit there, or someone can do something about it. It isn't even like suggestions piling up would be a bad thing to deal with. It does matter what ideas people have, so I made this poll #10336 |
This issue has been automatically marked as stale because there wasn’t any recent activity. It will be closed soon if no further action occurs. Thank you for your contributions! |
This issue has been put aside. It is currently unclear if it will ever be implemented as it seems to cover too narrow of a use case or doesn't seem to fit into Weblate. Please try to clarify the use case or consider proposing something more generic to make it useful to more users. |
Describe the issue
I want to leave suggestions for source strings.
If I understand it correctly the "read-only" flag is on by default and lifted when direct editing is turned on.
(Suggestions for source strings work for projects that also allow direct editing of source strings.)
In any event it isn't possible to leave suggestions for strings by default, (with "suggestions" turned on),
top of https://hosted.weblate.org/settings/remmina/remmina/#translation
and it isn't possible to remove the "read-only" flag. in the settings for any strings.
Says "read-only" is inherrited from project/component — English, but that is what I am trying to edit, and it isn't bulk-added…
I already tried
Steps to reproduce the behavior
Expected behavior
Suggestions should be allowed by default (as now), for all projects.
Screenshots
Exception traceback
No response
How do you run Weblate?
weblate.org service
Weblate versions
No response
Weblate deploy checks
No response
Additional context
I didn't try to turn on suggestion voting, which just sits at 0 votes.
Useful for people that don't have GitHub accounts, or don't want to leave suggestions in comments.
Would be a nice use-case for admins to come in and click yes or no to suggestions with direct editing that is only available to them.
The text was updated successfully, but these errors were encountered: