Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeError: Object.values is not a function #1

Open
alexkohler opened this issue Nov 19, 2017 · 2 comments
Open

TypeError: Object.values is not a function #1

alexkohler opened this issue Nov 19, 2017 · 2 comments

Comments

@alexkohler
Copy link

Gave this a try on Ubuntu 14.04, npm 5.4.22, node 6.11.3 and running into the following:

? Which website stack do you wanna browse ? (e.g. https://github.com) https://github.com
TypeError: Object.values is not a function
    at wappalyzer.analyze.then.json (/usr/lib/node_modules/stacks-cli/bin/cli.js:155:50)
@WeiChiaChang
Copy link
Owner

Hello @alexkohler, thanks for your time and patience first, and I found that it seems the Node.js version issue.

Objects.values finally got full support until version 7.0, so I'm sorry that's my fault.

I test on my local parallel virtual machine, Ubuntu 16.04, npm 5.5.1, node 8.9.1, here's the testing screenshot:

testing on ubuntu

And I think one of the solution is upgrade your node.js version to 7.0 at least to get full support of some ES2017 new feature like Object.values, further details can be found at here. Thanks you again, and I'll also try to figure out the other way without upgrading node version solution.

@alexkohler
Copy link
Author

Thanks @WeiChiaChang! That did the trick. I think just noting the minimum versions in the README would be plenty.

millette added a commit to millette/stacks-cli that referenced this issue Nov 21, 2017
Related to WeiChiaChang#1

Note that node 8.9.1 is the latest LTS, so that might be preferable instead of 7.0.0 - but I went by the comments in WeiChiaChang#1.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants