Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ValueError: val_set must contain 'X_ori' for model validation. #533

Open
1 of 2 tasks
petteriTeikari opened this issue Oct 2, 2024 · 1 comment
Open
1 of 2 tasks
Assignees
Labels
question Further information is requested

Comments

@petteriTeikari
Copy link

1. System Info

pypots: 0.8.1

2. Information

  • The official example scripts
  • My own created scripts

3. Reproduction

Use dataset_val in addition to the dataset (train_set) in the usage instructions

4. Expected behavior

Not sure which one you meant to be the correct key, but your documentation [1] says that there should be X in the dictinary, whereas your code says there should be X_ori [2]

And I guess the validation split needs to contain both X () and X_ori (without the missing values) which is not given in the documentation [1]?

e.g.

dataset_val = {"X": X_val_gt_missing, "X_ori": X_val_gt}

[1] https://docs.pypots.com/en/latest/pypots.imputation.html#pypots.imputation.csdi.CSDI.fit

[2]
image
image

@petteriTeikari petteriTeikari added the bug Something isn't working label Oct 2, 2024
@WenjieDu WenjieDu added question Further information is requested and removed bug Something isn't working labels Jan 23, 2025
@WenjieDu WenjieDu self-assigned this Jan 23, 2025
@WenjieDu
Copy link
Owner

Both X_ori and X can contain missing values. X_ori is the one holding ground truth values, and X is without them. X is for training, and X_ori is for the model to calculate training loss or validation error. If you still feel lost here, please read SAITS paper https://arxiv.org/abs/2202.08516 carefully

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants