Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bottom-sheet and Modal - Visual update #714

Closed
KateMacdonald opened this issue Feb 12, 2024 · 4 comments · Fixed by #731
Closed

Bottom-sheet and Modal - Visual update #714

KateMacdonald opened this issue Feb 12, 2024 · 4 comments · Fixed by #731
Assignees
@tomjackking
Labels
enhancement New feature or request

Comments

@KateMacdonald
Copy link
Collaborator

KateMacdonald commented Feb 12, 2024 •
edited
Loading

Visual update to both the Modal and the Modal state of the Bottom sheet.

Here is a link tot he Figma file, happy to discuss when ready: https://www.figma.com/file/WbAVpii2p7KDQYu1TPboyn/Modular-banking---Library-%26-Components-WIP?type=design&node-id=1721%3A8557&mode=design&t=tVEOMAUcoCJJQxGK-1
@KateMacdonald KateMacdonald added the enhancement New feature or request label Feb 12, 2024
@samithaf
Copy link
Collaborator

Please update the design and group with breakpoints.

@tomjackking tomjackking linked a pull request Feb 20, 2024 that will close this issue
Fixes/modal and bottom sheet visuals #731
Merged
@KateMacdonald
Copy link
Collaborator Author

@tomjackking Modal and Bottom sheet look great. Is it possible for the Modal to be vertically centred to match the Bottom-sheet?

@KateMacdonald
Copy link
Collaborator Author

@tomjackking Hey Tom, I just noticed that the Modal component is using the same Westpac brand colours for all other brands.

@tomjackking
Copy link
Collaborator

@tomjackking Hey Tom, I just noticed that the Modal component is using the same Westpac brand colours for all other brands.

This has been moved to #740

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tomjackking tomjackking

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes/modal and bottom sheet visuals WestpacGEL/GEL-next
3 participants
@samithaf @KateMacdonald @tomjackking