Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for No-Op Value #6

Open
tnovotny opened this issue Sep 10, 2017 · 2 comments
Open

Add support for No-Op Value #6

tnovotny opened this issue Sep 10, 2017 · 2 comments
Assignees
@WhiZTiM
Labels
bug

Comments

@tnovotny
Copy link

If I read the source code correctly then the No-Op value is not considered. This is especially important for the streams.
@tnovotny
Copy link
Author

tnovotny commented Sep 10, 2017 •
edited
Loading

just saw the
enum class Marker : byte { ... No_Op = 'N',
so I think this can just be closed

@WhiZTiM WhiZTiM self-assigned this Sep 12, 2017
@WhiZTiM
Copy link
Owner

WhiZTiM commented Sep 12, 2017 •
edited
Loading

You are right, while we do have the Marker::No_Op marker, I didn't consider it in the StreamReader. StreamWriter not having it can be an acceptable temporary limitation. However, it is definitely a bug that StreamReader doesn't have it. (What if we are reading UBJSON binary stream written by another client?).

Thanks! Added to my TODO list this weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@WhiZTiM WhiZTiM

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@WhiZTiM @tnovotny