Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

desktop #4 icon missing for optional icon types #4

Open
fredless opened this issue Feb 19, 2025 · 3 comments
Open

desktop #4 icon missing for optional icon types #4

fredless opened this issue Feb 19, 2025 · 3 comments

Comments

@fredless
Copy link

fredless commented Feb 19, 2025

when running --dark or --blue in release v1.2.0.0, desktop #4 shows no icon in the taskbar - and indeed resource file https://github.com/Wielding/Windicator/blob/e4d409fe45a540dddb106ccfa9989b382234fc25/resources/WinApp.rc also does not contain entries for these 2 icons

@Wielding
Copy link
Owner

I am sorry but I have stopped using Windows and moved to Linux and macOS so I don't currently have an environment to look at this. Maybe I will set up a VM one day to look into this but I can't say for sure when that will happen. I should probably communicate that in the README.

@Wielding
Copy link
Owner

I just looked quickly at the code and I do see that they are missing in the RC file as you said and it should be a quick fix. I never used the dark and blue options since those were requests from other people.

I also just realized that I might only be able to build Windows ARM binaries in the VM on my MacBook since it is running an ARM version of windows. That would mean I have to wait until I am in another location where I do have an old Windows machine available. That won't be for several weeks at least. After that I will probably archive the repository.

@Wielding
Copy link
Owner

Wielding commented Feb 28, 2025

I am back in my other location with a Windows machine available. I will be pushing a fix shortly. I thought I had more work ahead of me getting my Windows machine up to date, but it turns out there was not much to do, even though I have not touched it in quite a while.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants