Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move all pubsub topics and sensor types to constants #49

Open
2 of 6 tasks
Willmish opened this issue Mar 12, 2022 · 0 comments · May be fixed by #68
Open
2 of 6 tasks

Move all pubsub topics and sensor types to constants #49

Willmish opened this issue Mar 12, 2022 · 0 comments · May be fixed by #68
Assignees
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@Willmish
Copy link
Owner

Willmish commented Mar 12, 2022

In order to make Backend-frontend integration easier and smoother, move all string names of pubsub topics and snesor types to a single Constants.py file or Enums.

Possible solution:

  • Add a constants.py file in src/tools with those constants/create Enums for each (see src/tools/status.py for an example)
  • Move pubsub topics there
  • Move Sensor types there
  • Move Actuator types there
  • Move database manager names there? or remove them entirely
  • Maybe add default parameters there as well, to be stored (e.g. current pid values, selected data streamer (local SQL db/Azure DB/IoT Hub)

Possible storage files:

  • Python Enums
  • .env file
  • .ini config file and python configparser (May be the best option, for future integration, other system settings can be stored here!)
@Willmish Willmish added documentation Improvements or additions to documentation enhancement New feature or request labels Mar 12, 2022
@Willmish Willmish added this to the Demo presentation version milestone Mar 12, 2022
@Willmish Willmish self-assigned this Mar 12, 2022
@Willmish Willmish assigned angela24680403 and unassigned Willmish Mar 12, 2022
@Willmish Willmish linked a pull request Apr 6, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants