Faster random generator Issue

[Potothingi]

What feature do you want to see added?

If all chunks within the world border were generated before using the faster-random-generator, the structure will not be found. For example, if I use eyes of ender, the eyes of ender don't work.

I need a configuration that allows me to use legacy random for seeds, like the use-legacy-random-for-slime-chunk option.

[Potothingi]

Current Options:

  faster-random-generator:
    enabled: true
    # Which random generator will be used?
    # See https://openjdk.org/jeps/356
    random-generator: Xoroshiro128PlusPlus
    # Enable faster random generator for world generation.
    # WARNING: This will affect world generation!!!
    enable-for-worldgen: false
    # Warn if you are not using legacy random source for slime chunk generation.
    warn-for-slime-chunk: true
    # Use legacy random source for slime chunk generation,
    # to follow vanilla behavior.
    use-legacy-random-for-slime-chunk: true

[Potothingi]

@Dreeam-qwq

[HaHaWTH]

Cannot reproduce, and you should use bug report template to report bugs.

[Potothingi]

@HaHaWTH Thanks for the reply. But I can reproduce it. enable-for-worldgen: false affects world generation and structure finding. I don't know how to prove this to you.

I looked at the code and this looks suspicious.

Leaf/patches/server/0083-Faster-Random-Generator.patch

Line 535 in d6b323a

+ super(org.dreeam.leaf.config.modules.opt.FastRNG.enabled ? new org.dreeam.leaf.util.math.random.FasterRandomSource(0L) : new LegacyRandomSource(0L));

super(org.dreeam.leaf.config.modules.opt.FastRNG.enabled ? new org.dreeam.leaf.util.math.random.FasterRandomSource(0L) : new LegacyRandomSource(0L));
↓
super(org.dreeam.leaf.config.modules.opt.FastRNG.worldgenEnabled() ? new org.dreeam.leaf.util.math.random.FasterRandomSource(0L) : new LegacyRandomSource(0L));

Shouldn't it be changed like this? Please check. Thank you.

[HaHaWTH]

@HaHaWTH Thanks for the reply. But I can reproduce it. enable-for-worldgen: false affects world generation and structure finding. I don't know how to prove this to you.

I looked at the code and this looks suspicious.

Leaf/patches/server/0083-Faster-Random-Generator.patch

Line 535 in d6b323a

+ super(org.dreeam.leaf.config.modules.opt.FastRNG.enabled ? new org.dreeam.leaf.util.math.random.FasterRandomSource(0L) : new LegacyRandomSource(0L));

super(org.dreeam.leaf.config.modules.opt.FastRNG.enabled ? new org.dreeam.leaf.util.math.random.FasterRandomSource(0L) : new LegacyRandomSource(0L));
↓
super(org.dreeam.leaf.config.modules.opt.FastRNG.worldgenEnabled() ? new org.dreeam.leaf.util.math.random.FasterRandomSource(0L) : new LegacyRandomSource(0L));
Shouldn't it be changed like this? Please check. Thank you.

This only works when secure-seed enabled, did you enable secure seed?

[Potothingi]

I didn't enable it. :o

  # Once you enable secure seed, all ores and structures are generated with 1024-bit seed
  # instead of using 64-bit seed in vanilla, made seed cracker become impossible.
  secure-seed:
    enabled: false

[Potothingi]

Doesn't this affect seed?
This appears to only change Slime Seed to the Legacy RNG Seed. Other seeds will likely use the Fast RNG Seed.

Leaf/patches/server/0083-Faster-Random-Generator.patch

Lines 32 to 43 in d6b323a

	static RandomSource create(long seed) {
	- return new LegacyRandomSource(seed);
	+ return org.dreeam.leaf.config.modules.opt.FastRNG.enabled
	+ ? new org.dreeam.leaf.util.math.random.FasterRandomSource(seed)
	+ : new LegacyRandomSource(seed);
	+ }
	+
	+ static RandomSource createForSlimeChunk(long seed) {
	+ return org.dreeam.leaf.config.modules.opt.FastRNG.enabled && !org.dreeam.leaf.config.modules.opt.FastRNG.useLegacyForSlimeChunk
	+ ? new org.dreeam.leaf.util.math.random.FasterRandomSource(seed)
	+ : new LegacyRandomSource(seed);
	}

Leaf/patches/server/0083-Faster-Random-Generator.patch

Lines 154 to 160 in d6b323a

	public static RandomSource seedSlimeChunk(int chunkX, int chunkZ, long worldSeed, long scrambler) {
	- return RandomSource.create(
	+ return RandomSource.createForSlimeChunk(
	worldSeed + (long)(chunkX * chunkX * 4987142) + (long)(chunkX * 5947611) + (long)(chunkZ * chunkZ) * 4392871L + (long)(chunkZ * 389711) ^ scrambler
	- );
	+ ); // Leaf - Faster RNG
	}

[Potothingi]

@HaHaWTH It seems to me that not only Slime Seeds but also Structure Seeds are affected by Fast RNG.

This issue is not invalid because it was created for a feature request to use legacy RNG for seeds that affect the game, not just slime seeds.

[HaHaWTH]

@HaHaWTH It seems to me that not only Slime Seeds but also Structure Seeds are affected by Fast RNG.

This issue is not invalid because it was created for a feature request to use legacy RNG for seeds that affect the game, not just slime seeds.

Structure generation uses WorldgenRandom, which is backed by LegacyRandomSource. Code above is unlikely to cause this problem.