Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hidden-item-components breaking plugins #188

Open
3 of 4 tasks
s3nkwr opened this issue Dec 26, 2024 · 1 comment
Open
3 of 4 tasks

hidden-item-components breaking plugins #188

s3nkwr opened this issue Dec 26, 2024 · 1 comment
Assignees
Labels
bug Something isn't working Status: Confirmed This issue have been confirmed to be a Leaf bug

Comments

@s3nkwr
Copy link

s3nkwr commented Dec 26, 2024

Checklist

What behaviour is observed?

hidden-item-components breaking plugins

When I set hidden-item-components setting in the leaf config to ["custom_data"], plugins that use Persistent Data Container (PublicBukkitValues) were broken.

Old item (before changing config):

image
/paper dumpitem:

minecraft:player_head[custom_name='{"color":"white","italic":false,"text":"ItemCustom"}',custom_data={PublicBukkitValues: {"encrypted:encrypted_1": 1676851392252L, "encrypted:encrypted_2": "encrypted"}},profile={id: [I; -2114780278, 1474708730, -1841407185, 303123196], properties: [{name: "textures", value: "eyJ0ZXh0dXJlcyI6eyJTS0lOIjp7InVybCI6Imh0dHA6Ly90ZXh0dXJlcy5taW5lY3JhZnQubmV0L3RleHR1cmUvNzM5YWQ5YTA2M2FiOTBiN2FjNzJhNWQ0YzE3YWNiNGZiMDNkOGE4YzU4MmZiZTI4NTQyNDUzMzJiZDNkYjlhNyJ9fX0="}]}]

New item (after changing config & changing it back):

image
/paper dumpitem:

minecraft:player_head[profile={id: [I; -2114780278, 1474708730, -1841407185, 303123196], properties: [{name: "textures", value: "eyJ0ZXh0dXJlcyI6eyJTS0lOIjp7InVybCI6Imh0dHA6Ly90ZXh0dXJlcy5taW5lY3JhZnQubmV0L3RleHR1cmUvNzM5YWQ5YTA2M2FiOTBiN2FjNzJhNWQ0YzE3YWNiNGZiMDNkOGE4YzU4MmZiZTI4NTQyNDUzMzJiZDNkYjlhNyJ9fX0="}]},custom_name='{"color":"white","italic":false,"text":"ItemCustom"}']

Discord thread in #support forum: https://ptb.discord.com/channels/1145991395388162119/1315726450233577522

Expected behaviour

When I set hidden-item-components setting in the leaf config to ["custom_data"], plugins that use Persistent Data Container should work.

To Reproduce

  1. Set hidden-item-components: ["custom_data"] in leaf config.
  2. Start Leaf server.
  3. Existing items with custom_data component are now not usable anymore.

Spark profiler link

Dont need

Error log (if applicable)

No response

@s3nkwr s3nkwr added the bug Something isn't working label Dec 26, 2024
@Dreeam-qwq Dreeam-qwq self-assigned this Dec 26, 2024
@Energobro
Copy link

can confirm

@Dreeam-qwq Dreeam-qwq added the Status: Confirmed This issue have been confirmed to be a Leaf bug label Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Status: Confirmed This issue have been confirmed to be a Leaf bug
Projects
None yet
Development

No branches or pull requests

3 participants