From 601a1cfce11f096b90d954ebf99bdc1e9cfbcd7c Mon Sep 17 00:00:00 2001
From: Adam Wood <1017872+adamwoodnz@users.noreply.github.com>
Date: Wed, 23 Oct 2024 15:05:31 +1300
Subject: [PATCH] Replace customized tip notices with success notices

Stops standard tip notices in content from also being customized and displaying success icons.
This is more apparent after we've started rendering callout blocks as notice blocks.

See https://github.com/WordPress/wordpress.org/issues/374
---
 .../wporg-learn-2024/patterns/sensei-lesson-columns.php   | 2 +-
 .../pub/wporg-learn-2024/patterns/sensei-quiz-notices.php | 2 +-
 .../themes/pub/wporg-learn-2024/src/style/_sensei.scss    | 8 --------
 3 files changed, 2 insertions(+), 10 deletions(-)

diff --git a/wp-content/themes/pub/wporg-learn-2024/patterns/sensei-lesson-columns.php b/wp-content/themes/pub/wporg-learn-2024/patterns/sensei-lesson-columns.php
index 65621e078..c4434d459 100644
--- a/wp-content/themes/pub/wporg-learn-2024/patterns/sensei-lesson-columns.php
+++ b/wp-content/themes/pub/wporg-learn-2024/patterns/sensei-lesson-columns.php
@@ -29,7 +29,7 @@
 
 		<?php if ( $is_completed ) : ?>
 			<!-- wp:wporg/notice {"style":{"spacing":{"margin":{"top":"var:preset|spacing|20"}}}} -->
-			<div class="wp-block-wporg-notice is-tip-notice" 
+			<div class="wp-block-wporg-notice is-success-notice" 
 				style="<?php echo $module ? 'margin-top:var(--wp--preset--spacing--20)' : 'margin-bottom:var(--wp--preset--spacing--50)'; ?>">
 				<div class="wp-block-wporg-notice__icon"></div>
 				<div class="wp-block-wporg-notice__content">
diff --git a/wp-content/themes/pub/wporg-learn-2024/patterns/sensei-quiz-notices.php b/wp-content/themes/pub/wporg-learn-2024/patterns/sensei-quiz-notices.php
index 87cd8ef60..792b27d1d 100644
--- a/wp-content/themes/pub/wporg-learn-2024/patterns/sensei-quiz-notices.php
+++ b/wp-content/themes/pub/wporg-learn-2024/patterns/sensei-quiz-notices.php
@@ -27,7 +27,7 @@
 	<!-- /wp:wporg/notice -->
 <?php elseif ( $is_pending_grade ) : ?>
 	<!-- wp:wporg/notice {"style":{"spacing":{"margin":{"top":0,"bottom":"var:preset|spacing|40"}}}} -->
-	<div class="wp-block-wporg-notice is-tip-notice" style="margin-top:-10px;margin-bottom:var(--wp--preset--spacing--40)">
+	<div class="wp-block-wporg-notice is-success-notice" style="margin-top:-10px;margin-bottom:var(--wp--preset--spacing--40)">
 		<div class="wp-block-wporg-notice__icon"></div>
 		<div class="wp-block-wporg-notice__content">
 			<p><?php esc_html_e( 'Well done! You completed the quiz.', 'wporg-learn' ); ?></p>
diff --git a/wp-content/themes/pub/wporg-learn-2024/src/style/_sensei.scss b/wp-content/themes/pub/wporg-learn-2024/src/style/_sensei.scss
index b7c39f69d..50d5ff5a6 100644
--- a/wp-content/themes/pub/wporg-learn-2024/src/style/_sensei.scss
+++ b/wp-content/themes/pub/wporg-learn-2024/src/style/_sensei.scss
@@ -14,14 +14,6 @@ body.sensei {
 	--sensei-module-lesson-color: var(--wp--preset--color--charcoal-1);
 	--sensei-lm-mobile-header-height: 60px;
 
-	.is-tip-notice .wp-block-wporg-notice__icon {
-		background: url(../../assets/icon-check.svg);
-	}
-
-	.wp-block-wporg-notice__icon {
-		height: 24px;
-	}
-
 	.wp-block-sensei-lms-course-theme-notices:empty {
 		display: none;
 	}