-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Interactivity API: Iteration for WP 6.6 #60219
Comments
@DAreRodz @gziolo What's the best path to consider additional workstreams for the Interactivity API for 6.6? Context is that @westonruter and myself have been exploring ideas to facilitate better INP performance centrally via the Interactivity API. For instance, we could automatically yield certain actions and callbacks to the main thread to reduce contention between multiple event listeners. We're close to formalizing our proposal in an issue, and it would be great to eventually include this effort here, if the team is on board. One of the changes we're proposing may require a BC break in the API which we could handle with a deprecation strategy, but it would also benefit from being implemented sooner than later, now that the API is still very new and not yet as widely adopted outside of core. |
Hey @felixarntz, thanks for raising this up! 😊 I'm unsure what would be the "best path" (maybe @gziolo could help), but as this tracking issue is meant to be flexible, I would be happy to include your work. Let's wait for the proposal to see if we can have it ready for WP 6.6 and how the mentioned breaking changes could impact the current API. |
That sounds excellent, @felixarntz. I'm looking forward to seeing the proposal. @DAreRodz, the |
The ability to use existing WordPress Scripts from Script Modules is one of the most impactful things we can work on for the Interactivity API. Anything built with the Interactivity API must be a script module, so although it's not strictly Interactivity API, resolving this ticket for script and module interoperability seems very important: https://core.trac.wordpress.org/ticket/60647 |
Second @sirreal calls for WordPress scripts. We use |
Is there any chance to get interactivity api outside of blocks? For example in custom php templates? |
@ermincelikovic While I believe it's not documented, it should already be possible. The main caveat is that by default custom PHP templates wouldn't be processed server-side, so you have to make sure the attributes that are dynamic via the Interactivity API are initialized with their correct value. As a proof of concept, I have been working on WordPress/wordpress-develop#5795 where I am using the Interactivity API for all dynamic functionality of the Twenty Twenty-One theme. Maybe that's helpful. |
You can process them using |
This looks great! EDIT: |
I've added the suggestions in Typescripting utils PR. Ready to be reviewed again. |
@ermincelikovic The |
I've added two PRs to the description above.
The first one could be considered a bug fix (I've added it under that category), and so be released in a minor WP release. |
The fix for I've also opened an issue to fix the same problem in |
In addition to #60035 I'd love to see some more useful debugging for the following areas:
Besides debugging here are some other things that I would love to see in the 6.6 cycle.
|
I've added WordPress/wordpress-develop#6394 for server-side derived state. It's ready for review. |
I've just added 3 items related to
I think there's a bug with the server processing of ignore directives I'm attempting to fix in WordPress/wordpress-develop#6405. I think that nodes with that attribute and their descendants should be ignored completely, no processing should happen on or under a node with Right now ignore directives are not handled on the server, so those nodes and their descendants are processed. I discovered that while working on tests for #60744. |
I've created this ticket to handle property access on PHP objects in interactivity state, only arrays are well handled at the moment: https://core.trac.wordpress.org/ticket/61039 |
I've created a PR to add a couple of warnings if Server Directives processing fails. |
Created a PR to handle multiple |
Created a PR to avoid a wrong directive from killing the runtime. |
Added another PR, avoiding an emtpy or a wrong namespace from killing the runtime too. |
Added a follow-up issue to improve the readability of the directive processing function inside |
Added another performance issue which came out of the discussion in #60574 (comment): |
Added a minimum PR with two types: |
Based on discussion in #60979 (comment) I've opened a PR to add build configuration for a standalone package: |
I've started a PR to migrate |
Hi all 👋 Reminder: The release candidate for Gutenberg Version 18.5 is scheduled for next Friday (May 31st). So anything that is supposed to make it into WordPress 6.6 must be merged by then. Please raise any important issues that need additional attention :) |
Hi 👋 I updated the description of the main tracking issue with the list of PRs that won't be included in this release, the PRs that still needs review or commit and the PRs ready for 6.6. |
I've added WordPress/wordpress-develop#6453 as an enhancement for 6.6 (let Interactivity API be used in WP Admin). |
I've added a unit test to the bug fix for the fatal error if a state or context uses a stdClass. Ready to review: 👀 |
Added a merged a bug fix for |
Closing as finished. The work for WordPress 6.7 will be tracked in the following tracking issue: |
The new version introduced a BIG error... Now instead of returning an object, |
@otakupahp Will you please open a new issue with details about the problem? |
I would love, but I spend that time tracking the error, and I'm terrible creating those issues. But I found the reason for it. Before 6.6 I had an array with other arrays:
That create this JSON:
The Interactive API created a context object that contains the array without problems. Now, it just renders a string instead of an array object To fix the error, I have to modify my array into this:
Which created this JSON:
This is indeed parsed as an object. SO, I must patch my code to make it work... Maybe this was introduced on #6672 |
I have created an issue to investigate this bug: @otakupahp, could you please comment on that issue to provide a detailed list of the steps we need to take to reproduce the problem? Thank you. |
We completed everything for the first public release of the Interactivity API in WordPress 6.5. Now, during the next iteration―which is going to be shorter―, we aim to focus on improving the current API without releasing new features. This includes enhancing the developer experience (especially during debugging), better test coverage and code quality, as well as fixing any reported bugs.
Note that the list is expected to be modified. I've also added optional tasks we can work on if we find the time.
28-05 Update: All tasks have been redistributed for 6.6 release summary.
Punted to future releases
navigate()
Failure States #59856Won't do
Ready for 6.6
Enhancements
preact/debug
whenSCRIPT_DEBUG
is enabled #60514wp-on-async
directive as performant alternative over synchronouswp-on
directive #61885Bug fixes
data-wp-on
. #60661data-wp-on-document
anddata-wp-on-window
. #61009wp-each-child
priority. #62293Code Quality
toVdom
#61728utils.ts
#61721The text was updated successfully, but these errors were encountered: