Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make some top level menu links actual links #50

Open
joyously opened this issue Aug 16, 2019 · 2 comments
Open

Make some top level menu links actual links #50

joyously opened this issue Aug 16, 2019 · 2 comments

Comments

@joyously
Copy link
Contributor

The menus need to have top level links that go to content. I keep finding themes that change top level links to #. I assume it's because the test data does not have actual top level links, so authors don't realize that they can be.
Maybe the link could say it's a link or somehow mention what to check for somewhere.

@carolinan
Copy link

This is a common menu pattern. It has nothing to do with the test data, more likely it is because of the popularity of so called "mega menus". Authors can decide what kind of menu they want.

@joyously
Copy link
Contributor Author

What are you saying? I don't understand.
The issue is that the test data does not include both types of menus, and it should, so that authors know that they cannot willy-nilly change the top-level links of the user's menu.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants