Skip to content
This repository has been archived by the owner on Dec 1, 2019. It is now read-only.

Template files should not be slug specific: page-header.php #111

Closed
hareesh-pillai opened this issue Sep 8, 2019 · 3 comments
Closed

Template files should not be slug specific: page-header.php #111

hareesh-pillai opened this issue Sep 8, 2019 · 3 comments

Comments

@hareesh-pillai
Copy link
Contributor

Error reported by Theme Sniffer: Template files should not be slug specific. The file name used for this template will be interpreted by WP as page-header and only applied when a page with the slug header is loaded.

@joyously
Copy link

joyously commented Sep 8, 2019

While this is true that page-header.php would not be good in the main folder of the theme, apparently it's not an issue when it is in a subfolder.
I think it should probably be changed anyway, though.

test-for-page-header-file

@ernilambar
Copy link
Member

Error reported by Theme Sniffer: Template files should not be slug specific. The file name used for this template will be interpreted by WP as page-header and only applied when a page with the slug header is loaded.

This looks like bug in sniffer. When file is within subfolder, there should be no ERROR. I have created issue in the repo. WPTT/WPThemeReview#233

@carolinan
Copy link
Contributor

This file has been renamed to entry-header.php.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants