Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dusk: Site title is colored #604

Open
juanfra opened this issue Oct 21, 2024 · 3 comments · May be fixed by #610
Open

Dusk: Site title is colored #604

juanfra opened this issue Oct 21, 2024 · 3 comments · May be fixed by #610
Assignees
Labels
[Type] Bug An existing feature does not function as intended.

Comments

@juanfra
Copy link
Member

juanfra commented Oct 21, 2024

Description
The site title for Dusk is purple, but in the design, it's not colored.

Step-by-step reproduction instructions

  1. Activate the dusk variation.
  2. Check the site title color, and confirm it's not like in the designs.

Expected behavior

The expectation would be to match the designs.

Screenshots

Image

@juanfra juanfra added the [Type] Bug An existing feature does not function as intended. label Oct 21, 2024
@troychaplin
Copy link
Contributor

Just looking at this, I though removing the color references for site-title and the link element in styles/03-dusl.json would do the trick but it appears to not be the fix.

"core/site-title": {
	"color": {
		"text": "var:preset|color|accent-3"
	},
	"typography": {
		"fontFamily": "var:preset|font-family|vollkorn",
		"fontSize": "var:preset|font-size|x-large"
	},
	"elements": {
		"link": {
			"color": {
				"text": "var:preset|color|accent-3"
			}
		}
	}
}

@juanfra
Copy link
Member Author

juanfra commented Oct 21, 2024

@troychaplin thank you for looking at this! That should be in combination with changes in styles/colors/03-dusk.json

@troychaplin
Copy link
Contributor

@juanfra turns out it was an element style for links on the paragraph block

@troychaplin troychaplin self-assigned this Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug An existing feature does not function as intended.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants