From 00139436571717a3338a9a71ac003877bde1b25c Mon Sep 17 00:00:00 2001 From: Sukhendu Sekhar Guria Date: Wed, 18 Dec 2024 01:27:36 +0530 Subject: [PATCH 1/4] Fix: Pullquote citation color reflects selected text color --- src/wp-content/themes/twentynineteen/sass/blocks/_blocks.scss | 2 +- src/wp-content/themes/twentynineteen/style-editor.css | 2 +- src/wp-content/themes/twentynineteen/style-editor.scss | 2 +- src/wp-content/themes/twentynineteen/style-rtl.css | 2 +- src/wp-content/themes/twentynineteen/style.css | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/wp-content/themes/twentynineteen/sass/blocks/_blocks.scss b/src/wp-content/themes/twentynineteen/sass/blocks/_blocks.scss index af1ec47150159..353709adcf6d8 100644 --- a/src/wp-content/themes/twentynineteen/sass/blocks/_blocks.scss +++ b/src/wp-content/themes/twentynineteen/sass/blocks/_blocks.scss @@ -410,7 +410,7 @@ @include font-family( $font__heading ); line-height: 1.6; text-transform: none; - color: $color__text-light; + color: inherit; /* * This requires a rem-based font size calculation instead of our normal em-based one, diff --git a/src/wp-content/themes/twentynineteen/style-editor.css b/src/wp-content/themes/twentynineteen/style-editor.css index 5206b537e21cd..4d8ffc975b2fe 100644 --- a/src/wp-content/themes/twentynineteen/style-editor.css +++ b/src/wp-content/themes/twentynineteen/style-editor.css @@ -1100,7 +1100,7 @@ figcaption, } .wp-block-pullquote:not(.is-style-solid-color) .wp-block-pullquote__citation { - color: #767676; + color: inherit; } .wp-block-pullquote.is-style-solid-color blockquote { diff --git a/src/wp-content/themes/twentynineteen/style-editor.scss b/src/wp-content/themes/twentynineteen/style-editor.scss index c4c79817ae9cd..3e823dc5eb756 100644 --- a/src/wp-content/themes/twentynineteen/style-editor.scss +++ b/src/wp-content/themes/twentynineteen/style-editor.scss @@ -512,7 +512,7 @@ figcaption, } &:not(.is-style-solid-color) .wp-block-pullquote__citation { - color: $color__text-light; + color: inherit; } &.is-style-solid-color { diff --git a/src/wp-content/themes/twentynineteen/style-rtl.css b/src/wp-content/themes/twentynineteen/style-rtl.css index ad12cb46e1214..7b5a78dffbf67 100644 --- a/src/wp-content/themes/twentynineteen/style-rtl.css +++ b/src/wp-content/themes/twentynineteen/style-rtl.css @@ -5732,7 +5732,7 @@ body.page .main-navigation { font-family: -apple-system, BlinkMacSystemFont, "Segoe UI", "Roboto", "Oxygen", "Ubuntu", "Cantarell", "Fira Sans", "Droid Sans", "Helvetica Neue", sans-serif; line-height: 1.6; text-transform: none; - color: #767676; + color: inherit; /* * This requires a rem-based font size calculation instead of our normal em-based one, * because the cite tag sometimes gets wrapped in a p tag. This is equivalent to $font-size_xs. diff --git a/src/wp-content/themes/twentynineteen/style.css b/src/wp-content/themes/twentynineteen/style.css index c44b8fa99feea..3feb4f804943c 100644 --- a/src/wp-content/themes/twentynineteen/style.css +++ b/src/wp-content/themes/twentynineteen/style.css @@ -5744,7 +5744,7 @@ body.page .main-navigation { font-family: -apple-system, BlinkMacSystemFont, "Segoe UI", "Roboto", "Oxygen", "Ubuntu", "Cantarell", "Fira Sans", "Droid Sans", "Helvetica Neue", sans-serif; line-height: 1.6; text-transform: none; - color: #767676; + color: inherit; /* * This requires a rem-based font size calculation instead of our normal em-based one, * because the cite tag sometimes gets wrapped in a p tag. This is equivalent to $font-size_xs. From ed751650fec4fb80acfaa959bf5ec11e62d151e7 Mon Sep 17 00:00:00 2001 From: Sukhendu Sekhar Guria Date: Fri, 27 Dec 2024 16:41:52 +0530 Subject: [PATCH 2/4] Fix: Ensure proper color inheritance when background color use --- src/wp-content/themes/twentynineteen/style-editor.css | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/wp-content/themes/twentynineteen/style-editor.css b/src/wp-content/themes/twentynineteen/style-editor.css index 4d8ffc975b2fe..ea98bc38a8b19 100644 --- a/src/wp-content/themes/twentynineteen/style-editor.css +++ b/src/wp-content/themes/twentynineteen/style-editor.css @@ -1092,6 +1092,10 @@ figcaption, color: #000; } +.wp-block-pullquote blockquote p { + color: inherit; +} + .wp-block-pullquote blockquote { margin-top: calc(3 * 1rem); margin-bottom: calc(3.33 * 1rem); From 617b30c1da40e3ffc54421cf726585f541c51620 Mon Sep 17 00:00:00 2001 From: Sukhendu Sekhar Guria Date: Fri, 27 Dec 2024 16:55:46 +0530 Subject: [PATCH 3/4] Update SCSS file --- src/wp-content/themes/twentynineteen/style-editor.css | 4 ---- src/wp-content/themes/twentynineteen/style-editor.scss | 2 +- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/src/wp-content/themes/twentynineteen/style-editor.css b/src/wp-content/themes/twentynineteen/style-editor.css index ea98bc38a8b19..4d8ffc975b2fe 100644 --- a/src/wp-content/themes/twentynineteen/style-editor.css +++ b/src/wp-content/themes/twentynineteen/style-editor.css @@ -1092,10 +1092,6 @@ figcaption, color: #000; } -.wp-block-pullquote blockquote p { - color: inherit; -} - .wp-block-pullquote blockquote { margin-top: calc(3 * 1rem); margin-bottom: calc(3.33 * 1rem); diff --git a/src/wp-content/themes/twentynineteen/style-editor.scss b/src/wp-content/themes/twentynineteen/style-editor.scss index 3e823dc5eb756..71c9db7ac6760 100644 --- a/src/wp-content/themes/twentynineteen/style-editor.scss +++ b/src/wp-content/themes/twentynineteen/style-editor.scss @@ -555,6 +555,7 @@ figcaption, line-height: 1.3; margin-bottom: 0.5em; margin-top: 0.5em; + color: inherit; @include media(tablet) { font-size: $font__size-xl; @@ -960,7 +961,6 @@ $group-block-background__padding: $font__size_base; } } -// Full alignment .wp-block[data-align="full"] > .wp-block-group { // Margins & padding are added to this container to mimic From da1b4e098773873318287cba9d57566f6630f294 Mon Sep 17 00:00:00 2001 From: Sukhendu Sekhar Guria Date: Fri, 27 Dec 2024 17:01:19 +0530 Subject: [PATCH 4/4] Update style-editor css file --- src/wp-content/themes/twentynineteen/style-editor.css | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/wp-content/themes/twentynineteen/style-editor.css b/src/wp-content/themes/twentynineteen/style-editor.css index 4d8ffc975b2fe..a7b126b29485d 100644 --- a/src/wp-content/themes/twentynineteen/style-editor.css +++ b/src/wp-content/themes/twentynineteen/style-editor.css @@ -1099,6 +1099,10 @@ figcaption, word-break: break-word; } +.wp-block-pullquote blockquote p { + color: inherit; +} + .wp-block-pullquote:not(.is-style-solid-color) .wp-block-pullquote__citation { color: inherit; }