Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playground link is not working #1881

Closed
sudip-md opened this issue Oct 10, 2024 · 5 comments
Closed

Playground link is not working #1881

sudip-md opened this issue Oct 10, 2024 · 5 comments
Assignees
Labels
[Type] Bug An existing feature does not function as intended

Comments

@sudip-md
Copy link

Click on playground this link which is mentioned in WordPress/twentytwentyfive#544

Error Log
https://playground.wordpress.net/#%7B%22steps%22:%5B%7B%22step%22:%22login%22,%22username%22:%22admin%22,%22password%22:%22password%22%7D,%7B%22step%22:%22installPlugin%22,%22pluginZipFile%22:%7B%22resource%22:%22wordpress.org/plugins%22,%22slug%22:%22theme-check%22%7D,%22options%22:%7B%22activate%22:true%7D%7D,%7B%22step%22:%22installTheme%22,%22themeZipFile%22:%7B%22resource%22:%22url%22,%22url%22:%22https://github-proxy.com/proxy.php?action=archive&repo=WordPress%2Ftwentytwentyfive&branch=update%2Flist%22%7D%7D,%7B%22step%22:%22activateTheme%22,%22themeFolderName%22:%22twentytwentyfive-update/list%22%7D%5D%7D

@bgrgicak
Copy link
Collaborator

@sudip-md the preview workflow in the Twenty Twenty-Five repository will need to be updated to fix Playground previews.

The WordPress version required for Twenty Twenty-Five is 6.7, so you need to set "wp": "nightly" in the blueprint.

The activateTheme step breaks because the theme is stored in a folder named twentytwentyfive-update-list and the blueprint expects a theme under the path twentytwentyfive-update/list.
This can be resolved by removing the activateTheme and adding "options": { "activate": true } to the installTheme step.
@vcanales This could be a good improvement to https://github.com/vcanales/action-wp-playground-pr-preview as it would benefit all workflows.

This is how a working blueprint would look like:

{
  "preferredVersions": {
      "php": "8.0",
      "wp": "nightly"
  },
  "steps": [
      {
          "step": "login",
          "username": "admin",
          "password": "password"
      },
      {
          "step": "installPlugin",
          "pluginData": {
              "resource": "wordpress.org/plugins",
              "slug": "theme-check"
          },
          "options": {
              "activate": true
          }
      },
      {
          "step": "installTheme",
          "themeData": {
              "resource": "url",
              "url": "https://github-proxy.com/proxy.php?action=archive&repo=WordPress%2Ftwentytwentyfive&branch=update%2Fzoomout"
          },
          "options": {
				"activate": true
			}
		}
	]
}

Here is a related conversation about this error in the WordPress community Slack.

@bgrgicak bgrgicak moved this from Inbox to Needs Author's Reply in Playground Board Oct 10, 2024
@vcanales
Copy link
Member

@vcanales This could be a good improvement to https://github.com/vcanales/action-wp-playground-pr-preview as it would benefit all workflows.

I see that the links are broken now because the blueprint schema has changed, apparently?
I won't have time to move over to the new schema; let me know if you'd like to take ownership of the repo and I'll transfer it.

@adamziel adamziel moved this from Needs Author's Reply to Inbox in Playground Board Oct 13, 2024
@bgrgicak
Copy link
Collaborator

I see that the links are broken now because the blueprint schema has changed, apparently?

pluginZipFileand themeZipFile are now deprecated in favor of pluginData and themeData, but they still work.

@vcanales feel free to transfer the repo to me it shouldn't be a lot of work to keep it up to date and I'm happy to do it.

@bgrgicak bgrgicak self-assigned this Oct 14, 2024
@bgrgicak bgrgicak added [Type] Bug An existing feature does not function as intended [Package][@wp-playground] Blueprints and removed [Package][@wp-playground] Blueprints labels Oct 14, 2024
@bgrgicak
Copy link
Collaborator

@brandonpayton @adamziel I'm considering moving vcanales/action-wp-playground-pr-preview to Playground Tools. Would you prefer for it to stay a separate repository?

@bgrgicak bgrgicak moved this from Inbox to Needs Author's Reply in Playground Board Oct 14, 2024
@bgrgicak
Copy link
Collaborator

We moved action-wp-playground-pr-preview and @juanfra fixed the issue which prevented Twentytwentyfive PRs from working. The fix affects only new PRs, older PR previews won't work because the URL isn't correct.

There is another issue related to previewing PRs from forks which @juanfra is also working on.

Since there isn't anything for us to do in the Playground project, I will close this issue.

Kudos to @juanfra for working on these fixes! 🚀

@github-project-automation github-project-automation bot moved this from Needs Author's Reply to Done in Playground Board Oct 30, 2024
@adamziel adamziel moved this from Done to Inbox in Playground Board Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug An existing feature does not function as intended
Projects
Archived in project
Development

No branches or pull requests

4 participants