Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make blogs: Convert callout blocks to notice blocks #374

Assignees

Comments

@adamwoodnz
Copy link

adamwoodnz commented Sep 24, 2024

The Make blogs have old style callout blocks:

These need to display as notice blocks. We added a mu-plugin to convert callout shortcodes to notices, perhaps we can use a similar approach, or failing that, add these fallback styles to the parent theme.

This should also address the styles of the callout blocks on Learn.

@jonathanbossenger
Copy link

Adding an example lesson using old callouts for testing: https://learn.wordpress.org/lesson/how-classic-and-block-themes-are-developed/

@adamwoodnz
Copy link
Author

Adding an example lesson using old callouts for testing: https://learn.wordpress.org/lesson/how-classic-and-block-themes-are-developed/

Sorry, but I can't see any callouts in that lesson, has it been updated?

@adamwoodnz
Copy link
Author

Adding an example lesson using old callouts for testing: https://learn.wordpress.org/lesson/how-classic-and-block-themes-are-developed/

Sorry, but I can't see any callouts in that lesson, has it been updated?

Ignore me, I just couldn't see them because of the broken styling. Here's what they look like once converted to notice via the mu-plugins change:

Image

I'm not quite sure why the callout blocks are completely broken now, it looks like they can't even be inserted anymore... investigating.

@adamwoodnz
Copy link
Author

I'm not quite sure why the callout blocks are completely broken now, it looks like they can't even be inserted anymore... investigating.

Discovered that callout blocks are part of the Handbook plugin, so they broke when we deactivated it.

@adamwoodnz
Copy link
Author

Closed by WordPress/wporg-mu-plugins#660

adamwoodnz added a commit to WordPress/Learn that referenced this issue Oct 23, 2024
Stops standard tip notices in content from also being customized and displaying success icons.
This is more apparent after we've started rendering callout blocks as notice blocks.

See WordPress/wordpress.org#374
@adamwoodnz
Copy link
Author

Still issues with o2, now causing recursive loops and timeouts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment