Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Path and Link Broken in Theme Security Handbook #509

Open
marcarmengou opened this issue Apr 25, 2024 · 3 comments
Open

Path and Link Broken in Theme Security Handbook #509

marcarmengou opened this issue Apr 25, 2024 · 3 comments

Comments

@marcarmengou
Copy link

Moving this issue WordPress/wporg-main-2022#435 here as suggested by @pkevan

Original issue:

In the new WordPress.org translation strings I found a broken link to a section of the Theme Handbook that does not yet exist.

  • The link:

https://github.com/WordPress/wporg-main-2022/blob/618fd76e47510e15fa0184ccd03d52562c1814f0/source/wp-content/themes/wporg-main-2022/patterns/about-security.php#L40

  • Theme security path:

From the complete link address https://developer.wordpress.org/themes/theme-security/theme-security-issues/ the upper section does not exist either /theme-security/

@pkevan
Copy link
Contributor

pkevan commented Apr 25, 2024

@marcarmengou the page should now work - can you let me know if it doesn't?

@marcarmengou
Copy link
Author

Thanks @pkevan. The page is now publicly visible.

On the other hand I see that https://developer.wordpress.org/themes/theme-security/ has a 301 redirect to https://developer.wordpress.org/themes/theme-security/theme-security-issues/ If the redirect is only temporary, perhaps you should use a 302.

Just to confirm if this is correct for you. The only way to access the resource https://developer.wordpress.org/themes/theme-security/theme-security-issues/ is through the link on this page https://wordpress.org/about/security/, since the top page https://developer.wordpress.org/themes/theme-security/ does not exist or is not publicly visible in https://developer.wordpress.org/themes/

@carolinan
Copy link

carolinan commented Jul 29, 2024

Issues related to the Theme developer handbook can be opened in the documentation issue tracker and labeled with themes:
https://github.com/WordPress/Documentation-Issue-Tracker

Tickets in this repository, wporg-developer, is not monitored by members of the Themes team that manages the content of this handbook, and the team would need to be notified.

This page https://developer.wordpress.org/themes/theme-security/theme-security-issues/ is not intended to be published in the Theme developer handbook. Its content is not related to theme development but to themes in the theme directory.

The existing page related to security is https://developer.wordpress.org/themes/advanced-topics/security/

This page https://developer.wordpress.org/themes/theme-security/ is intended to help users who arrive at this page from links that have not been updated, instead of arriving on a 404. It is not intended to be redirected to
https://developer.wordpress.org/themes/theme-security/theme-security-issues/

It is supposed to have information about contents being moved to https://developer.wordpress.org/apis/security/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants