Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: sharedSecret isn't passed in properly #77

Open
hendrix04 opened this issue Jul 12, 2024 · 2 comments
Open

Bug: sharedSecret isn't passed in properly #77

hendrix04 opened this issue Jul 12, 2024 · 2 comments

Comments

@hendrix04
Copy link

hendrix04 commented Jul 12, 2024

When trying to update a trigger (and likely in other situations), sharedSecret is ignored in favor of sharedKey (which I don't think exists anymore in BTT).

I believe the issue is at

let parameters = this.params(data, config.sharedKey);

@Worie
Copy link
Owner

Worie commented Jul 12, 2024

It would be good to see in which btt version this change was introduced to keep the compatibility with older versions, but on the other hand, a major release with such a change probably wouldn't hurt in this case :)

@hendrix04
Copy link
Author

The good news is that BTT doesn't seem to care if you pass in too many parameters that it has no idea what to do with. I think if both were allowed to pass through (if it were set in the config in the first place) that things would just work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants