Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve theming support #1501

Closed
myvuuu opened this issue Mar 10, 2022 · 1 comment
Closed

Improve theming support #1501

myvuuu opened this issue Mar 10, 2022 · 1 comment
Labels
accessibility needs-design Extra attention from design is needed

Comments

@myvuuu
Copy link
Collaborator

myvuuu commented Mar 10, 2022

Only 30-40% of Canvas components support theming (and only for colorful items), we need to provide theming support for:

  • TBD

This is not dependent on rolling out the new color system, but would be ideal to start after IE11 retires for more CSS functionality.

Open Questions:

  • Do we want to support dark mode?

  • Do we want to wait until after the new color system rolls out?

  • How holistic should theming be?

** Waiting for more confirmation about what needs to be themed and the new color system model.

@myvuuu myvuuu added enhancement New feature or request needs-design Extra attention from design is needed p:2 labels Mar 10, 2022
@jaclynjessup jaclynjessup moved this to 2️⃣ Medium in Canvas Kit Aug 1, 2022
@jaclynjessup jaclynjessup removed p:2 enhancement New feature or request labels Aug 5, 2022
@jaclynjessup jaclynjessup moved this to 🧊 Ice Box in Canvas Kit Oct 5, 2022
@mannycarrera4
Copy link
Contributor

I'm gonna close this as this is part of the work of us updating our components to use our new tokens.

@github-project-automation github-project-automation bot moved this from 🧊 Ice Box to ✅ Done in Canvas Kit Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility needs-design Extra attention from design is needed
Projects
Status: ✅ Done
Status: Done
Development

No branches or pull requests

3 participants