Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spike: Define all component to add a style props support #1903

Closed
RayRedGoose opened this issue Nov 7, 2022 · 3 comments
Closed

Spike: Define all component to add a style props support #1903

RayRedGoose opened this issue Nov 7, 2022 · 3 comments

Comments

@RayRedGoose
Copy link
Contributor

RayRedGoose commented Nov 7, 2022

🔍 Spike / Exploration

All our components should have a common styling API just like they have a common compound component API. It makes API more predictable for users and requires less actions for modification.

What questions would be answered once this spike was completed?

  1. What components doesn't support style props now?
  2. What components should have a style props support?
  3. How do we add a style props support to these components (replace by layout component or spread a styles from boxStylesFn?
  4. v8 or v9 changes?
@RayRedGoose RayRedGoose self-assigned this Nov 7, 2022
@workday-canvas-kit workday-canvas-kit moved this to 🆕 New in Canvas Kit Nov 7, 2022
@jaclynjessup jaclynjessup removed the status in Canvas Kit Nov 9, 2022
@jaclynjessup jaclynjessup moved this to 🔖 Ready in Canvas Kit Nov 17, 2022
@RayRedGoose RayRedGoose moved this from 🔖 Ready to 🏗 In progress in Canvas Kit Dec 7, 2022
@RayRedGoose
Copy link
Contributor Author

LABS:

PREVIEW:

MAIN:

CAN BE MODIFIED:

  • Badge
  • SystemIcon
  • LoadingDots
  • Skeleton
  • Table
  • TextArea - can use style props (preview already has)
  • TextInput - can use style props (preview already has)

@alanbsmith
Copy link
Member

alanbsmith commented Jul 6, 2023

Update:

Table, Skeleton, and SystemIcon have been updated already. Below are sandboxes for other components on the list.

@RayRedGoose RayRedGoose removed their assignment Dec 11, 2023
@alanbsmith
Copy link
Member

Closing. We're moving away from style-props in favor of static styling.

@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Canvas Kit Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

2 participants