Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: SearchForm is forwarding props to DOM elements #2458

Closed
alanbsmith opened this issue Dec 11, 2023 · 2 comments · Fixed by #2850
Closed

Bug: SearchForm is forwarding props to DOM elements #2458

alanbsmith opened this issue Dec 11, 2023 · 2 comments · Fixed by #2850
Labels
10.x bug Something isn't working good first issue Good for newcomers help wanted Good for experienced contributors

Comments

@alanbsmith
Copy link
Member

alanbsmith commented Dec 11, 2023 •
edited
Loading

🐛 Bug Report

SearchForm is forwarding component props to the underlying DOM element.

  • isCollapsed
  • isHidden
  • showForm
  • shouldShow

To Reproduce

  • See the sandbox linked below

Link to repl or repo (highly encouraged)

Sandbox

Error Output

Warning: React does not recognize the `shouldShow` prop on a DOM element. If you 
intentionally want it to appear in the DOM as a custom attribute, spell it as 
lowercase `shouldshow` instead. If you accidentally passed it from a parent component, 
remove it from the DOM element.
button
@alanbsmith alanbsmith added the bug Something isn't working label Dec 11, 2023
@github-project-automation github-project-automation bot moved this to 🆕 New in Canvas Kit Dec 11, 2023
@alanbsmith alanbsmith added help wanted Good for experienced contributors good first issue Good for newcomers 10.x and removed good first issue Good for newcomers labels Dec 11, 2023
@alanbsmith
Copy link
Member Author

This isn't breaking anything, but we should clean it up.

@myvuuu myvuuu moved this from 🆕 New to 📋 To Do in Canvas Kit Feb 6, 2024
@dawitadmassu
Copy link

Hi @alanbsmith

I want to contribute here.
I can help on cleaning this up. can you give me your guidance?

@thunguyen19 thunguyen19 mentioned this issue Aug 1, 2024
Merged
@github-project-automation github-project-automation bot moved this from 📋 To Do to ✅ Done in Canvas Kit Aug 5, 2024
@jaclynjessup jaclynjessup removed this from Canvas Kit Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
10.x bug Something isn't working good first issue Good for newcomers help wanted Good for experienced contributors
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(SearchForm): Suppress forwarding props warning thunguyen19/canvas-kit
2 participants
@alanbsmith @dawitadmassu