You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Update the MenuModel to use the same context as the PopupModel. This will allow Menu to use the same components as Popup like Popup.CloseIcon. I don't see a downside or breaking change to this.
Motivation
All other popup-type components like Modal, Dialog, etc use the same model context as the PopupModel. The Menu doesn't follow this. If you want to add a Popup.CloseIcon, you have to hoist the menu model and pass it to the CloseIcon component.
The text was updated successfully, but these errors were encountered:
💡 Suggestion
Update the MenuModel to use the same context as the PopupModel. This will allow
Menu
to use the same components asPopup
likePopup.CloseIcon
. I don't see a downside or breaking change to this.Motivation
All other popup-type components like
Modal
,Dialog
, etc use the same model context as thePopupModel
. TheMenu
doesn't follow this. If you want to add aPopup.CloseIcon
, you have to hoist the menu model and pass it to theCloseIcon
component.The text was updated successfully, but these errors were encountered: