Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the MenuModel to use the same context as the PopupModel #2495

Open
NicholasBoll opened this issue Jan 3, 2024 · 0 comments
Open

Update the MenuModel to use the same context as the PopupModel #2495

NicholasBoll opened this issue Jan 3, 2024 · 0 comments

Comments

@NicholasBoll
Copy link
Member

💡 Suggestion

Update the MenuModel to use the same context as the PopupModel. This will allow Menu to use the same components as Popup like Popup.CloseIcon. I don't see a downside or breaking change to this.

Motivation

All other popup-type components like Modal, Dialog, etc use the same model context as the PopupModel. The Menu doesn't follow this. If you want to add a Popup.CloseIcon, you have to hoist the menu model and pass it to the CloseIcon component.

@jaclynjessup jaclynjessup moved this to 🆕 New in Canvas Kit Jan 3, 2024
@myvuuu myvuuu moved this from 🆕 New to 🔖 Ready in Canvas Kit Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🔖 Ready
Development

No branches or pull requests

1 participant