Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix querying public extraction function #245

Closed
3 tasks done
cbutsko opened this issue Jan 9, 2025 · 0 comments · Fixed by #246
Closed
3 tasks done

Fix querying public extraction function #245

cbutsko opened this issue Jan 9, 2025 · 0 comments · Fixed by #246
Assignees
@cbutsko
Labels
bug Something isn't working

Comments

@cbutsko
Copy link
Contributor

cbutsko commented Jan 9, 2025 •
edited
Loading

Currently, selection of public extractions based on a user-defined season is faulty. For Belgium, providing almost any season that does not have center in June results in losing almost all samples.

To Do:

  • fix get_best_valid_date function that causes the issue of losing samples based on provided season
  • add comprehensive test
  • refactor duplicate process_parquet function to avoid conflicts with original function from presto-worldcereal repo
@cbutsko cbutsko self-assigned this Jan 9, 2025
@cbutsko cbutsko added the bug Something isn't working label Jan 9, 2025
@cbutsko cbutsko linked a pull request Jan 9, 2025 that will close this issue
245 fix querying public extraction function #246
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cbutsko cbutsko

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

245 fix querying public extraction function WorldCereal/worldcereal-classification
1 participant
@cbutsko