Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabs restored in reverse order (workaround: set aside and restore them twice) #108

Open
maxstarkenburg opened this issue Apr 5, 2023 · 1 comment
Assignees
Labels
bug Something isn't working help wanted Extra attention is needed need more info

Comments

@maxstarkenburg
Copy link

maxstarkenburg commented Apr 5, 2023

Description

I was testing out this extension because was looking for something to group tabs by (though I think it's intention/applicability on Firefox is a bit different, so probably won't fulfill my needs). In any case, after setting current tabs aside (and being a bit surprised that it set aside all my unpinned tabs), I then restored all the tabs.

Unfortunately, it restored all the tabs in the reverse order than how they were originally ordered. I thought I'd be faced with a task of now having to manually re-order ~60 tabs to get them how I wanted again, but I inadvertently set them all aside yet again (it might be worth a separate issue that I think clicking the (?) next to "Set current tabs aside" executes said setting aside (my expectation was for it to open an explanatory dialog or something)). The silver lining was that, upon second restore, the tabs were once again in original desired order.

Reproduction steps

See above.

Expected behavior

I'd expect them to get restored in their original order (w/o having to do so twice).

Screenshots

If applicable, add screenshots to help explain your problem.

Environment

Please provide the following information:

  • Operating System: MacOS Ventura 13.2.1
  • Browser: Firefox 111.0.1 (64 bit)
  • Extension version: 2.0.5

Additional context

Aside: I originally had difficulty finding this repo, since from https://addons.mozilla.org/en-US/firefox/addon/ms-edge-tabs-aside/, under "Hey, It's open-source software!", the "GitHub Repository" link went to a 404 (and non-GitHub) page.

@maxstarkenburg maxstarkenburg added the bug Something isn't working label Apr 5, 2023
@XFox111 XFox111 self-assigned this Apr 6, 2023
@XFox111
Copy link
Owner

XFox111 commented Apr 7, 2023

Hi @maxstarkenburg. Thanks for your feedback!

I've checked the issue. It looks fine on Firefox 111.0.1 64-bit on Windows. So maybe it has something to do with MacOS. If it's the case, unfortunately, I have no means to investigate the issue or fix it without help

In any case, after setting current tabs aside (and being a bit surprised that it set aside all my unpinned tabs)

This is intended behavior. This extension was designed to be temporary storage for tabs (e.g. you are working on task A and then you need to switch to task B, so you set tabs related to task A aside and then go back after some time).

Another way is to select multiple tabs (by holding Ctrl or Shift) and then clicking the action link (this is what that question mark icon was supposed to say)

I inadvertently set them all aside yet again (it might be worth a separate issue that I think clicking the (?) next to "Set current tabs aside" executes said setting aside (my expectation was for it to open an explanatory dialog or something)).

This question mark icon indeed shows an explanatory text, but instead of clicking it, you should hover your cursor over it. It is a bad design, so as a temporary fix, I'll separate this icon from the link in the next patch update.

Aside: I originally had difficulty finding this repo, since from https://addons.mozilla.org/en-US/firefox/addon/ms-edge-tabs-aside/, under "Hey, It's open-source software!", the "GitHub Repository" link went to a 404 (and non-GitHub) page.

Yeah, sorry for that. I've already fixed the links

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed need more info
Projects
None yet
Development

No branches or pull requests

2 participants