Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look into X-Forwarded-For (Version: 2.1.0) #1207

Closed
godexsoft opened this issue Feb 23, 2024 · 3 comments
Closed

Look into X-Forwarded-For (Version: 2.1.0) #1207

godexsoft opened this issue Feb 23, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request research
Milestone

Comments

@godexsoft
Copy link
Collaborator

Summary

Look into supporting X-Forwarded-For.

Motivation

It would be useful to support proxies and load balancers.

Solution

Leverage the X-Forwarded-For header.

@godexsoft godexsoft added enhancement New feature or request research labels Feb 23, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Clio Feb 23, 2024
@godexsoft
Copy link
Collaborator Author

There needs to be a list of whitelisted IPs (proxy for example) for which this header will be used. If we allow everyone to use the header we basically grant unlimited usage to anyone sending random IPs.

@godexsoft godexsoft added this to the 2.3 milestone Jun 18, 2024
@kennyzlei
Copy link
Collaborator

related rippled PR XRPLF/rippled#4009

@cindyyan317 cindyyan317 self-assigned this Sep 4, 2024
@cindyyan317
Copy link
Collaborator

After initial investigation, we decide to support it in Clio to provide safer traffic limitation. The actual implementation will be done by #1641.

@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Merged in Clio Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request research
Projects
Status: ✅ Merged
Development

No branches or pull requests

3 participants