Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IT logging to honor the correct environment. #584

Open
sappenin opened this issue Dec 16, 2024 · 0 comments
Open

Fix IT logging to honor the correct environment. #584

sappenin opened this issue Dec 16, 2024 · 0 comments

Comments

@sappenin
Copy link
Collaborator

Logging emissions like this one...

22:32:37.543 [main] INFO  org.xrpl.xrpl4j.tests.EscrowIT - EscrowCreate transaction successful: https://testnet.xrpl.org/transactions/989B07D8D7A8622E6D15F8BD7F2F9207347E256EF6B8A5BD2A57FB353B159F72

... should honor the environment that the test is running in. For example, when running in the DevNet, this URL should show devnet. Likewise, when running locally, these should display the URL of the rippled running in the local Docker container. In other words, we should source the domain for these from a helper function that inspects the currently running environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant