Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not work with Cloudflare workers due to dependency on axios #27

Open
davidhouweling opened this issue Nov 3, 2024 · 0 comments · May be fixed by #28
Open

Does not work with Cloudflare workers due to dependency on axios #27

davidhouweling opened this issue Nov 3, 2024 · 0 comments · May be fixed by #28
Labels
bug Something isn't working

Comments

@davidhouweling
Copy link

Context

I've been utilising this library for a bot i'm working on and it does work as expected.

However, I'm attempting to convert it to be a Cloudflare Worker and it isn't supported due to some of the capabilities not aligning.

One approach would be to allow for the setup of the authentication to take in a custom axios fetch adapter such as https://github.com/haverstack/axios-fetch-adapter which patches the issue, but ultimately given the support now for native fetch in both browser and Node 18+ it would be worth just switching to native fetch and removing the axios dependency all together.

I've drafted up the work locally and have proven it works at least for the node use case. I'll raise a PR and leave it to project owners if they wish to take it on.

@davidhouweling davidhouweling linked a pull request Nov 3, 2024 that will close this issue
@Alexis-Bize Alexis-Bize added the bug Something isn't working label Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants