Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about categorical channels in LSTM input features #113

Open
EduCasta opened this issue May 4, 2021 · 0 comments
Open

Question about categorical channels in LSTM input features #113

EduCasta opened this issue May 4, 2021 · 0 comments

Comments

@EduCasta
Copy link

EduCasta commented May 4, 2021

Dear authors, contributors, and maintainers of the repository,

First of all, I would like to thank you for the availability of this repository. I am currently working on a university project with this benchmark for the mortality prediction task, using the LSTM models.

I have a question about the final 76 features that you use for your LSTM model benchmarks. In particular, I have a question about the number of channels existing for the categorical variables. I noticed in the file “discretizer_config.json”, which is used in the discretization step, you consider as different category values that might be equal. See for example the possible values for the Glasgow Coma Verbal Response: "No Response-ETT", "No Response", "1 No Response", "1.0 ET/Trach”. These have each a different feature channel; however, they seem to represent the same value: “No Response”.

In fact, they all share the same value in the “channel_info.json” file; however, this might not have been included in the discretization. I only found one reference to this file in the function “mimic3models/common_utils.extract_features_from_rawdata”, which is unused in the discretization step for the LSTM data-preprocessing, although it is used for the logistic regression.

What I described happens in almost all categories. Would it be possible that you share a clarification on this matter?

Thank you very much for your time in advance.

Best regards,
Eduardo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant