Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design issue with Whip_Requirement #32

Open
schlessera opened this issue Mar 8, 2017 · 0 comments
Open

Design issue with Whip_Requirement #32

schlessera opened this issue Mar 8, 2017 · 0 comments

Comments

@schlessera
Copy link
Contributor

The interface Whip_Requirement wants to be an abstract requirement that only knows about a ::component(). However, in Whip_RequirementsChecker::requirementIsFulfilled(), the requirements version() is being checked, despite the interface not having such a method.

So, either Whip_Requirement is actually a Whip_VersionRequirement, or the Whip_RequirementsChecker::requirementIsFulfilled() needs to abstract away what it actually checks.

To abstract this away, it can delegate the isFulfilled() to the requirement itself with all related knowledge it has.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants