Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue when setting memory_mode as OutplaceEmphasis() in DICG. #506

Open
WenjieXiao-2022 opened this issue Sep 25, 2024 · 1 comment
Open

Comments

@WenjieXiao-2022
Copy link

In the /test/decomposition_invariant.jl, when run the DICG standard run for ProbabilitySimplex oracle, if we specify the memory_mode as OutplaceEmphasis(), the starting point x0, which is obatined by compute_extrem_point(), will be ScaledHotVector() type.

In OutplaceEmphasis() mode, x0 will not be converted into SparseArrays but compute_extrem_point() and compute_inface_extrem_point() both require x to be SparseArrays. Therefore it throws error as !match.

Some kind of check and conversion might be necessary if it is OutplaceEmphasis() and starting point is not SparseArrays for ProbabilitySimplex oracle.

@matbesancon
Copy link
Member

that's a good point, we rarely test with OutplaceEmphasis TBH because one can often work around for immutable types, it would be worth a PR still

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants