Setting allowances and charges generate invalid xml

[ozonni]

Hello team,

i'm setting allowances and charges for each line item

lineItem.addCharge(new Charge()
                            .setPercent(surcharge.getPercent())
                            .setTotalAmount(surcharge.getTotalAmount())
                            .setTaxPercent(lineItem.getProduct().getVATPercent())
                            .setReasonCode("ZZZ")
                            .setCategoryCode(TaxCategoryCodeTypeConstants.STANDARDRATE)
                            .setReason(surcharge.getReason()));

When i take xml result and validate online, i get the following errors:

Looking here:

mustangproject/library/src/main/java/org/mustangproject/ZUGFeRD/ZUGFeRD2PullProvider.java

Line 268 in 404598b

protected String getAllowanceChargeStr(IZUGFeRDAllowanceCharge allowance, IAbsoluteValueProvider item) {

there is no CategoryTradeTax | TypeCode | ActualTradeCurrencyExchange added

[jstaerk]

sounds similar to #640 do you have source code and/or xml for me to reproduce as
library\src\test\java\org\mustangproject\ZUGFeRD\ZF2PushTest.java:testItemChargesAllowancesExport seems to deliver a valid result?

[ozonni]

var lineItems = new ArrayList<IZUGFeRDExportableItem>();
var lineItem = new Item(new Product(item.getDescription(), "", "C62", new BigDecimal(item.getVat())),
                    item.getUnitPrice(),
                    item.getQuantity()
            );

lineItem.addAllowance(new Allowance()
                            .setPercent(allowance.getPercent())
                            .setTotalAmount(allowance.getTotalAmount())
                            .setTaxPercent(lineItem.getProduct().getVATPercent())
                            .setReasonCode("95")
                            .setCategoryCode(TaxCategoryCodeTypeConstants.STANDARDRATE)
                            .setReason(allowance.getReason()));

Invoice i = new Invoice();
i.setZFItems(lineItems);

ZUGFeRD2PullProvider zf2p = new ZUGFeRD2PullProvider();
zf2p.setProfile(Profiles.getByName("XRECHNUNG"));
zf2p.generateXML(i);

<ram:AppliedTradeAllowanceCharge>
            <ram:ChargeIndicator>
              <udt:Indicator>false</udt:Indicator>
            </ram:ChargeIndicator>
            <ram:ActualAmount>2.0000</ram:ActualAmount>
            <ram:Reason>WAT Reason 120</ram:Reason>
            <ram:ReasonCode>95</ram:ReasonCode>
          </ram:AppliedTradeAllowanceCharge>

[FrankHossfeld]

This is my code, which I use to generate a allowance:

invoice.addAllowance(new Allowance(model.getTotalAmount()).setReason(model.getText())
                                                                         .setPercent(model.getValue())
                                                                         .setTaxPercent(model.getSteuersatz())
                                                                         .setReasonCode("95"));

Try not setting the category code.

[ozonni]

@FrankHossfeld but that way you set allowance on the invoice level, meaning it's global allowance not related to any line item. What i'm doing is setting allowance for specific line item lineItem.addAllowance

[FrankHossfeld]

@ozonni Thanks for clarifying. I was triggered by @jstaerk's comment. And yes, the problem inside the other issue is related to charges and allowance of document level. But I am remember seeing this error also. Playing around with the input helped solving the problem

[ozonni]

@FrankHossfeld did you have the same error before? can you explain how you fixed it?

[FrankHossfeld]

With the latest update (2.26.0) the reasoncode "95"/"104" does no longer work.

no, sorry, can't remember. It was just in the beginning as I tried to get the electronic invoice running.

[FrankHossfeld]

looking at your code:

lineItem.addAllowance(new Allowance()
                            .setPercent(allowance.getPercent())
                            .setTotalAmount(allowance.getTotalAmount())
                            .setTaxPercent(lineItem.getProduct().getVATPercent())
                            .setReasonCode("95")
                            .setCategoryCode(TaxCategoryCodeTypeConstants.STANDARDRATE)
                            .setReason(allowance.getReason()));

I am a little bit surprised to see things like: setPercent(allowance.getPercent()). I am sure, this is an allowance created just before. HAve you tired to set percent to BigDecimal.TEN? I, in your place, would just play around and see, if the validation result change.

Update

"95" is no valid value for reason code and will create a validation error in 2.26.0.

[ozonni]

@jstaerk https://github.com/ZUGFeRD/mustangproject/blob/404598bb846b66c5c63368dd5c741ad6c69f3d34/library/src/main/java/org/mustangproject/ZUGFeRD/ZUGFeRD2PullProvider.java#L753C19-L753C35

why is CategoryTradeTax added here but not for allowances for individual charges?

[ozonni]

mustangproject/library/src/main/java/org/mustangproject/ZUGFeRD/ZUGFeRD2PullProvider.java

Line 446 in 51eb9d5

if (currentItem.getItemTotalAllowances() != null && currentItem.getItemTotalAllowances().length > 0) {

this code is never executed since getItemTotalAllowances always returns null in the default implementation in the interface.

Tbh i'm lost now and don't understand how mustang handles allowances. Seems like allowances and charges are not support atm by this library.

[jstaerk]

Hi

lineItem.addAllowance(new Allowance()
.setPercent(allowance.getPercent())
.setTotalAmount(allowance.getTotalAmount())
.setTaxPercent(lineItem.getProduct().getVATPercent())
.setReasonCode("95")
.setCategoryCode(TaxCategoryCodeTypeConstants.STANDARDRATE)
.setReason(allowance.getReason()));

please either use a absolute (setTotalAmount) or a relative (setPercent) Allowance

kind regards
Jochen