Duplicate InvoiceReferencedDocument elements in corrected XRechnung (TypeCode 384) with invoice.setCorrection()

[thomasweitzel]

When generating XML files with the Mustangproject v2.16.2 and using setCorrection on the invoice, I get an invalid XML.

A Java fragment:

Invoice invoice = new Invoice();
/*using some setters except `setCorrection` */
invoice.setCorrection("test-123");

Excerpt from the generated XML file (the element InvoiceReferencedDocument appears twice with the same contents):

<ram:InvoiceReferencedDocument>
    <ram:IssuerAssignedID>test-123</ram:IssuerAssignedID>
</ram:InvoiceReferencedDocument>
<ram:InvoiceReferencedDocument>
    <ram:IssuerAssignedID>test-123</ram:IssuerAssignedID>
</ram:InvoiceReferencedDocument>

The XML is generated like this:

ZUGFeRD2PullProvider zf2p = new ZUGFeRD2PullProvider();
zf2p.setProfile(Profiles.getByName("XRechnung", 3));
zf2p.generateXML(invoice);
String theXML = new String(zf2p.getXML());

I'm using Java-22, but the problem is present with Java-21 (LTS), too.

[thomasweitzel]

Upon further investigation: the problem was caused by commit 5d741586 (2024-12-24 14:29 by cs), that added a line to Invoice.setCorrection: addInvoiceReferencedDocument ...

public Invoice setCorrection(String number) {
    setInvoiceReferencedDocumentID(number);
    addInvoiceReferencedDocument(new ReferencedDocument(number)); // <--
    documentCode = DocumentCodeTypeConstants.CORRECTEDINVOICE;
    return this;
}

When I remove this line, the XML is valid again.

There was much more added with this change, which probably had a good reason, but that I don't understand ;-)

@christoph-sommer