Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect author and date selected #378

Open
unhip opened this issue Aug 17, 2021 · 3 comments
Open

Incorrect author and date selected #378

unhip opened this issue Aug 17, 2021 · 3 comments

Comments

@unhip
Copy link

unhip commented Aug 17, 2021

Hello,
Just Read oftentimes says "Unknown author" while the author of the article is clearly listed.
Just Read always indicates today's date, not the publication date.
It may skip illustrations.
E. g., try to read this article with Just Read. The publication date is 15.08.2021, the author is Антон Ходасевич (Anton Khodasevitch).

@unhip
Copy link
Author

unhip commented Aug 17, 2021

@ZachSaucier
Copy link
Owner

ZachSaucier commented Aug 17, 2021

Hey unhip.

These issues are because of how Just Read is set up to work.

The first two issues (incorrect author and/or date) are very related. There is no agreed upon standard for listing that info on websites, so Just Read does its best job of guessing what the author and date are based on the info it can find in the website. But what is easily apparent to us humans visually is not always as easy to find out programmatically. You can view the code for selecting the author here and the code for the date here. If you can figure out a better way to do either or both of these selections across all websites, I'd love to hear about it!

The skipping image issue is a bit different. Just Read is currently set up to view the article content of whatever is currently being rendered. However many websites lazy load imagery once the user has scrolled to a particular section. But again, there's no standard for lazy loading images, so Just Read doesn't currently attempt to load any images that are supposed to be lazy loaded. If you have a suggestion to how Just Read can do a better job of lazy loading images, I'd again love to hear about it!

@ZachSaucier
Copy link
Owner

I'm going to turn this into an issue about the incorrect author and date being selected.

@ZachSaucier ZachSaucier changed the title Errors Incorrect author and date selected Sep 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants