Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking: Support invalidating and reconsidering blocks in the NonFinalizedState via RPC methods #8634

Open
9 tasks
Tracked by #8632
arya2 opened this issue Jun 20, 2024 · 0 comments
Open
9 tasks
Tracked by #8632
Labels
A-rpc Area: Remote Procedure Call interfaces A-state Area: State / database changes C-testing Category: These are tests

Comments

@arya2
Copy link
Contributor

arya2 commented Jun 20, 2024

Motivation

This would be useful for testing forks and chain reorganizations, it was mentioned in the forums as a requirement for dex support and in the Regtest tracking issue.

See this comment for more information about the motivation.

Design

Add invalidate()/reconsider_block() methods to the NonFinalizedState, accept a new channel in write_blocks_from_channels() running in the the block write task (or refactor the existing channels into a single channel receiving an enum), add StateService Request variants for invalidating/reconsidering blocks, and add the invalidate()/reconsiderblock() RPC methods that call the StateService with the new Request variants.

Implementation Plan:

@arya2 arya2 changed the title Tracking: Support invalidating and reconsidering blocks in the NonFinalizedState Tracking: Support invalidating and reconsidering blocks in the NonFinalizedState Jun 20, 2024
@arya2 arya2 changed the title Tracking: Support invalidating and reconsidering blocks in the NonFinalizedState Tracking: Support invalidating and reconsidering blocks in the NonFinalizedState via RPC methods Jun 20, 2024
@arya2 arya2 added C-testing Category: These are tests A-rpc Area: Remote Procedure Call interfaces A-state Area: State / database changes labels Jun 20, 2024
@mpguerra mpguerra added this to the Zebra can replace `zcashd` milestone Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rpc Area: Remote Procedure Call interfaces A-state Area: State / database changes C-testing Category: These are tests
Projects
Status: New
Development

No branches or pull requests

2 participants