Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor message sending to host in `zRollupBuildInWorker #39

Open
iNewLegend opened this issue May 23, 2024 · 0 comments
Open

Refactor message sending to host in `zRollupBuildInWorker #39

iNewLegend opened this issue May 23, 2024 · 0 comments
Labels
todo has to be done

Comments

@iNewLegend
Copy link
Member

Title: Refactor message sending to host in zRollupBuildInWorker

Description:
The current implementation in zRollupBuildInWorker sends a formatted message to the host, which is not considered best practice. This needs to be refactored to improve code quality and maintainability.

File:
packages/zenflux-cli/src/core/build.ts

Current Code:

// TODO: Sending formated message to the host, not the best practice.
host.sendMessage("message", "build", "prepare", config.outputName);

Suggested Improvement:

  • Refactor the code to use a more appropriate method for sending messages to the host.
  • Consider using sendVerbose or sendMessage with a different approach that does not involve passing formatted messages directly.

Additional Context:
This change is aimed at improving the clarity and maintainability of the code. The current approach of sending formatted messages directly is not ideal and should be revised.

Feel free to adjust the issue details as needed!

Originally posted by @codiumai-pr-agent-pro[bot] in #35 (comment)

@iNewLegend iNewLegend added the todo has to be done label May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
todo has to be done
Projects
None yet
Development

No branches or pull requests

1 participant