Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor type declarations #48

Open
rrw-zilliqa opened this issue Oct 4, 2023 · 1 comment
Open

Refactor type declarations #48

rrw-zilliqa opened this issue Oct 4, 2023 · 1 comment

Comments

@rrw-zilliqa
Copy link
Contributor

We have a lot of scattered type declarations, imported in random places (the most notorious example is ScillaContractDeployer, which declares a bunch of types that really shouldn't be there now that the code has grown bigger).

Refactor to put our type decls in more reasonable places and import them everywhere they're needed.
@its-saeed
Copy link
Contributor

One more note to this ticket. I believe most of our types can be replaced with zilliqa-js ones.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@its-saeed @rrw-zilliqa