Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MintAndBurnTokenManager (and possibly others) do not revert when you ask them to transfer to an unknown destination. #24

Open
rrw-zilliqa opened this issue Dec 23, 2024 · 0 comments
Open

MintAndBurnTokenManager (and possibly others) do not revert when you ask them to transfer to an unknown destination. #24

rrw-zilliqa opened this issue Dec 23, 2024 · 0 comments
Assignees
@rrw-zilliqa

Comments

@rrw-zilliqa
Copy link
Contributor

When we're asked to transfer tokens, we look up the remote token address in our lookup table. If the table doesn't include an address, we get 0x0 and attempt to transfer tokens to address 0x0 on the remote chain.

Two problems - first, this will credit native tokens if the chain id exists. Second, it will eat the source tokens.
@rrw-zilliqa rrw-zilliqa self-assigned this Dec 23, 2024
rrw-zilliqa added a commit that referenced this issue Dec 24, 2024
@rrw-zilliqa
(feat) An exceptions facility so that we can retroactively correct (s…
da22940 
…o long as we have enough validators agreeing) "bad" transactions like those arising from #24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rrw-zilliqa rrw-zilliqa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rrw-zilliqa