Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What should count as a severance? #9

Open
dabreegster opened this issue Jan 20, 2024 · 6 comments
Open

What should count as a severance? #9

dabreegster opened this issue Jan 20, 2024 · 6 comments
Labels
good first issue Good for newcomers

Comments

@dabreegster
Copy link
Collaborator

Based just on OSM tags, currently a severance is when highway is motorway, trunk, primary, or those 3 with _link. I made this definition for Hong Kong. Do the results look correct everywhere? If it should be refined somewhere, please link to the OSM way that's either a false positive or negative (use debug mode and click).

@dabreegster dabreegster added the good first issue Good for newcomers label Jan 20, 2024
@dabreegster
Copy link
Collaborator Author

Railways, bodies of water, and even parks with gates around them should also count

@democat3457
Copy link

democat3457 commented Aug 8, 2024

This seems to be a false positive https://www.openstreetmap.org/way/1120402115#map=18/32.98030/-96.75926
while the neighboring secondary road is arguably dangerous to cross https://www.openstreetmap.org/way/419452359#map=19/32.98048/-96.75672 (or are severances supposed to be physically impossible to cross)

@dabreegster
Copy link
Collaborator Author

Thanks for reporting, I'm going to take another stab at this tomorrow and introduce "profiles." Originally I made this project to look at Hong Kong, then later on some places in the UK, and even between those two, the definition of severance is kind of different. Now looking at some places in the US (like this), it's wrong there too.

A severance should be anything that's physically impossible to cross (like a river or active rail line) or dangerous to cross for a pedestrian (many lanes, high speed, etc). That way, any crossings over the severances will be highlighted, and the lack of them studyable. I've been using highway classification as a proxy, which is OK in some places, but in many cases not.

@democat3457
Copy link

Also, ways with sidewalk=no should not be labeled "WithTraffic": https://www.openstreetmap.org/way/571968303

dabreegster added a commit that referenced this issue Aug 9, 2024
@dabreegster
Copy link
Collaborator Author

@democat3457, I started a (awfully named) "USA" profile: https://github.com/a-b-street/severance_snape/blob/main/backend/src/profiles.rs
Also added UT Dallas to the example list (for my own testing convenience mostly). Note it's using cached OSM data as of ~an hour ago, it's not updated unless I manually do it.
image
This looks much better to me, but there are still problems, like distinguishing https://www.openstreetmap.org/way/1120402115 and https://www.openstreetmap.org/way/571968303. If you have opinions about the classification in this area, please feel free to play with the code directly (if it's easy) or help me find more unit test cases

@dabreegster
Copy link
Collaborator Author

With these revisions, it picks up some pretty awful problems like
image
(Separately -- I need to find a basemap that's much better at showing lots of labels, because it's kind of impossible to know where this is. I have some ideas for rethinking the cartography totally, but it might take a while)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants