Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS: Evaluate time between Attestation and Assertion #1

Open
JesusMcCloud opened this issue Apr 26, 2023 · 2 comments
Open

iOS: Evaluate time between Attestation and Assertion #1

JesusMcCloud opened this issue Apr 26, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request platform:ios

Comments

@JesusMcCloud
Copy link
Collaborator

JesusMcCloud commented Apr 26, 2023

Currently, no checks are performed, wrt the time difference between the creation of an attestation and an assertion.
This is especially important for the key attestation scenario, since an assertion are created right after an attestation.
As the assertion contains no signature time, the only indication we have, is the time difference between the creation of an attestation and the point in time the assertion is checked.

Is this even sensible here, or should this be handled in whichever business logic integrates this library (i.e. through expiring nonces)?

Possible implementation: Make this check optional through a nullable configuration parameter.

Discussion point:

  • sane default?
  • null by default?
  • no defaults?
@nodh
Copy link
Contributor

nodh commented Apr 28, 2023

The way we are using attestation and assertion, we should define the default maximum time of 30 seconds between these two steps.

@JesusMcCloud
Copy link
Collaborator Author

assertion contains no timestamp. What do?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request platform:ios
Projects
None yet
Development

No branches or pull requests

2 participants