Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML Attributes that have a : in the middle of the name truncate everything before the : #324

Closed
briangwaltney opened this issue Apr 22, 2024 · 8 comments · Fixed by ocaml/opam-repository#26500
Labels

Comments

@briangwaltney
Copy link

Dream.html {|<div my:attr="test"></div>|}

The above code will produce:

<div attr="test"></div>

as output.

This prevents many features in common libraries like Alpinejs that utilize attributes with this style.

@briangwaltney
Copy link
Author

This is an issue with Dream_livereload not with Dream. Sorry...

@aantron
Copy link
Owner

aantron commented Aug 21, 2024

Reopening, as Dream_livereload was merged into Dream (in somewhat modified form).

@maxRN
Copy link
Contributor

maxRN commented Sep 4, 2024

Was able to reproduce. Most likely the same bug as in aantron/lambdasoup#12

@aantron
Copy link
Owner

aantron commented Sep 4, 2024

Disregard my message, which I deleted. Had a fog brain moment.

@aantron
Copy link
Owner

aantron commented Sep 5, 2024

@maxRN would you be able to try your repro again with your PR aantron/lambdasoup#61 (thank you!)? A pin opam pin lambdasoup --dev-repo should be sufficient IIRC, as the PR is now merged.

@maxRN
Copy link
Contributor

maxRN commented Sep 5, 2024

@aantron no more lost namespaces! The bug is fixed for Dream.livereload as well.

@aantron
Copy link
Owner

aantron commented Sep 6, 2024

Many thanks!

@aantron aantron closed this as completed Sep 6, 2024
@aantron
Copy link
Owner

aantron commented Sep 6, 2024

@maxRN for the repro and fix, @briangwaltney for the report and patience!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants