Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There is no indication of shortcuts in the menu... #688

Open
qua-rus opened this issue Aug 1, 2024 · 7 comments
Open

There is no indication of shortcuts in the menu... #688

qua-rus opened this issue Aug 1, 2024 · 7 comments

Comments

@qua-rus
Copy link
Contributor

qua-rus commented Aug 1, 2024

Edit > Selection... >

  • Move to next cell TAB
  • Move to previous cell SHIFT+TAB
  • Move Selection Left LEFT
  • Move Selection Right RIGHT
  • Move Selection Up UP
  • Move Selection Down DOWN

Снимок_20240801_124913

Edit > Text Editing... >

  • Cursor Left LEFT
  • Cursor Right RIGHT

Снимок_20240801_125107

View >

  • Switch to &next file/tab CTRL+TAB
  • Switch to &previous file/tab CTRL+SHIFT+TAB

Снимок_20240801_125200

@aardappel
Copy link
Owner

These are visible in English, so it may have something to do with the localization?

@qua-rus
Copy link
Contributor Author

qua-rus commented Aug 2, 2024

Maybe, but I don't know where to look...

@tobiolo
Copy link
Collaborator

tobiolo commented Aug 2, 2024

I can confirm that the accelerators are not displayed for the menu entries indicated above - Tested it with locale set to English, C, German, Russian...

@tobiolo
Copy link
Collaborator

tobiolo commented Aug 2, 2024

But this is due to technical debt on the GTK side:
https://docs.wxwidgets.org/latest/classwx_menu_item.html#a8b0517fb35e3eada66b51568aa87f261
image
These accelerator keys (like Tab, but also Right, Left, Down etc.) are not supported by GTK so it is logical for wxWidgets to suppress the display of the accelerator keys on wxGTK, although TreeSheets implements them manually.

@tobiolo
Copy link
Collaborator

tobiolo commented Aug 2, 2024

So as long
a) these accelerator keys are not supported in wxGTK for menu items, thus making it right to suppress their display in the menu items AND
b) we implement them manually
it should be as-is today because wxWidgets cannot expect programmers work around the limitation as it is done by TreeSheets?

@aardappel
Copy link
Owner

I guess the most useful thing of shortcuts showing up there is for users to learn the keys.

If we wanted to display them anyway, maybe we could make a function that does if wxgtk: "{name} ({key})" else: "{name}\t{key}" ?

@tobiolo
Copy link
Collaborator

tobiolo commented Aug 4, 2024

I guess the most useful thing of shortcuts showing up there is for users to learn the keys.

If we wanted to display them anyway, maybe we could make a function that does if wxgtk: "{name} ({key})" else: "{name}\t{key}" ?

That seems a valid approach to me, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants