Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only cards with string matching the search query should be displayed. #31

Open
aashish-ak opened this issue Dec 31, 2018 · 3 comments
Open
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@aashish-ak
Copy link
Owner

On searching for "Bha", this was the result:
bhak
As "Bha" is only present in "Bhakti Joshi" 's name, so only her card should be visible.

On searching of "Bhak" , following was the result:
bhak2
which is partially correct as "Ankush Bag" 's name does not contain "Bhak", so his card should not be there.

@aashish-ak aashish-ak added bug Something isn't working help wanted Extra attention is needed labels Dec 31, 2018
@dheeraj135
Copy link
Contributor

Actually, this is because of fuzziness parameter in search query. Currently searching of name is done using fuzzy search. If we want partial matching, we can use this.

@aashish-ak
Copy link
Owner Author

Yes this is good, or this can also be done like using union of results of the string.includes() method and Elastic Search, are you willing to work on this?

@dheeraj135
Copy link
Contributor

I will work on it, when I get some time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants