Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing trailing errors for golang lint #369

Open
mrtrkmn opened this issue Apr 14, 2020 · 0 comments
Open

fixing trailing errors for golang lint #369

mrtrkmn opened this issue Apr 14, 2020 · 0 comments

Comments

@mrtrkmn
Copy link
Member

mrtrkmn commented Apr 14, 2020

There are bunch of errors and warnings when we run linting for the project, could be nice that we have linting in CI process and obey the rules of it. Here is a screenshot from the results of running following command in root directory of the project.

curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s v1.24.0
./bin/golangci-lint run -D errcheck

Some parts of errors :

Screenshot 2020-04-14 at 14 13 49

I have added them into github actions test workflow, however I did not enable it, once the issues regarding to this command has been fixed, we can re-enable it along the way.

It is open to discussion that whether should we have a linting mechanism or not, do not hesitate to discuss below by sharing your opinion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant