Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Random test failures due to crt.sh #132

Open
kidmose opened this issue Apr 23, 2020 · 1 comment · May be fixed by #133
Open

Random test failures due to crt.sh #132

kidmose opened this issue Apr 23, 2020 · 1 comment · May be fixed by #133
Assignees
@gianmarcomennecozzi

Comments

@kidmose
Copy link
Collaborator

kidmose commented Apr 23, 2020

We see test errors comming and going intermittently in richkit.retrieve.cert_sh and richkit.retrieve.ctlogs, apparently because www.crt.sh is unreliable.

This has negative impact on how useful the unittesting is.

The fix seems to be to do away with the current bad practice of testing against a live API (Bad for exactly this reason).
@kidmose
Copy link
Collaborator Author

kidmose commented Apr 23, 2020

Assigning you, @gianmarcomennecozzi , as I believe you are on your way with a fix (change tests to use a mock server, insted of the live API)

kidmose added a commit that referenced this issue Apr 23, 2020
@kidmose
Merge pull request #131 from aau-network-security/feature/create-make…
46bb08f 
…file-#130

Feature/create makefile #130

Fixes #131 
Merging despite errors; They appear to fall under #132
@gianmarcomennecozzi gianmarcomennecozzi linked a pull request Apr 24, 2020 that will close this issue
implemented mock server for crt.sh #133
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gianmarcomennecozzi gianmarcomennecozzi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

implemented mock server for crt.sh aau-network-security/richkit
2 participants
@kidmose @gianmarcomennecozzi