You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In GhoAaveSteward, among the checks done in _validateReservesUpdate there are two which might be conflicting to achieve the same result.
The first is maxAllowed change on the individual borrowRateConfigs (optimalUsageRatio, baseVariableBorrowRate, variableRateSlope1, variableRateSlope2) and the maxVariableBorrowRate (baseVariableBorrowRate + variableRateSlope1 + variableRateSlope2).
The former is configurable (with borrowRateConfig) but the latter has a hard cap of 25%
which does not make sense practically for remote chains (arb currently is at 52.5%) as the value seems too low.
One suggestion is to remove the maxVariableBorrowRate check or make the maxAllowed value configurable which can be adjusted on a market-to-market basis.
In
GhoAaveSteward
, among the checks done in_validateReservesUpdate
there are two which might be conflicting to achieve the same result.The first is maxAllowed change on the individual borrowRateConfigs (
optimalUsageRatio
,baseVariableBorrowRate
,variableRateSlope1
,variableRateSlope2
) and the maxVariableBorrowRate (baseVariableBorrowRate + variableRateSlope1 + variableRateSlope2
).The former is configurable (with
borrowRateConfig
) but the latter has a hard cap of 25%gho-core/src/contracts/misc/GhoAaveSteward.sol
Line 25 in 3684128
which does not make sense practically for remote chains (arb currently is at 52.5%) as the value seems too low.
One suggestion is to remove the maxVariableBorrowRate check or make the maxAllowed value configurable which can be adjusted on a market-to-market basis.
gho-core/src/contracts/misc/GhoAaveSteward.sol
Lines 221 to 237 in 3684128
The text was updated successfully, but these errors were encountered: